feat: Add ability to use archives for certain server commands#1610
Draft
ploubser wants to merge 1 commit intonats-io:mainfrom
Draft
feat: Add ability to use archives for certain server commands#1610ploubser wants to merge 1 commit intonats-io:mainfrom
ploubser wants to merge 1 commit intonats-io:mainfrom
Conversation
Add the DataSource interface with server and archive implementations. This allows us to let certain server commands inspect the archived data instead of querying servers. There is no behavioral changes when querying servers from the DataSource implementation. The same doReq callback is used to get responses, but the interface allows us to simulate these reponses by looking at the archive contents and responding with the data contained in it. `server report` and `server request` commands are the first commands to have been ported to use this interface where it makes sense. The --archive flag activates this feature and will warn and or fail when used with invalid filter flags. Signed-off-by: Pieter Loubser <ploubser@gmail.com>
ploubser
force-pushed
the
archive_interface
branch
from
dd37dbf to
e71ec7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the DataSource interface with server and archive implementations. This allows us to let certain server commands inspect the archived data instead of querying servers.
There is no behavioral changes when querying servers from the DataSource implementation. The same doReq callback is used to get responses, but the interface allows us to simulate these reponses by looking at the archive contents and responding with the data contained in it.
server reportandserver requestcommands are the first commands to have been ported to use this interface where it makes sense. The --archive flag activates this feature and will warn and or fail when used with invalid filter flags.