Report observer status in cluster replicas for streams and consumers#877
Report observer status in cluster replicas for streams and consumers#877neilalexander wants to merge 1 commit intomainfrom
Conversation
|
Dependent on nats.go and jsm.go PRs before the |
ripienaar
left a comment
There was a problem hiding this comment.
comment about replace
|
|
||
| go 1.20 | ||
|
|
||
| replace github.com/nats-io/jsm.go => github.com/nats-io/jsm.go v0.1.1-0.20230926090317-6fb84b8ef01d |
There was a problem hiding this comment.
I'd rather not have these and instead update the dependency to point to the commit.
I keep forgetting about these and then do a release with them in which then end up failing go install installation method - happened when I did 0.1.0 and then had to do 0.1.1.
So hoping to avoid this mistake all together if I can :)
There was a problem hiding this comment.
Yep, these will be removed as commented above but for now it's just so that CI does the right thing while in draft state.
There was a problem hiding this comment.
Oh, sorry, I missed the comment you left there :)
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
2c433d3 to
5e2c2a4
Compare
This is to support nats-io/nats-server#4582.
Signed-off-by: Neil Twigg neil@nats.io