Fix WaveFileChunkReader.ReadWaveHeader: wrong reader advance (on RF64 files)#1231
Open
Audio-sohn wants to merge 1 commit intonaudio:masterfrom
Open
Fix WaveFileChunkReader.ReadWaveHeader: wrong reader advance (on RF64 files)#1231Audio-sohn wants to merge 1 commit intonaudio:masterfrom
Audio-sohn wants to merge 1 commit intonaudio:masterfrom
Conversation
During chunk reading the reader is always advanced by `chunkLength`. This breaks RF64 files, since the correct value is `dataChunkLength` (which was read from ds64 earlier and is only being overwritten with standard WAVE files). As a result, reader loses sync with chunk positions when dealing with RF64 Files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had problems with getting large RF64 WAVs to read properly. Turns out that the header reader had a small bug that caused it to lose sync with chunk start points, trying to load everything inbetween jumps into ram (since it thinks its some chunk with metadata or similar), which then either crashes the process or throws the riff chunk length exception, should the datachunk length exceed the int32 size limit.
During chunk reading the reader is always advanced by
chunkLength. This breaks RF64 files, since the correct value isdataChunkLength(which was read from ds64 earlier and is only being overwritten with standard WAVE files). As a result, reader loses sync with chunk positions when dealing with RF64 Files.