Improve multi-channel playback compatibility in WASAPI exclusive mode#1234
Open
kashiken wants to merge 4 commits intonaudio:masterfrom
Open
Improve multi-channel playback compatibility in WASAPI exclusive mode#1234kashiken wants to merge 4 commits intonaudio:masterfrom
kashiken wants to merge 4 commits intonaudio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves playback compatibility for multi-channel audio devices in WASAPI exclusive mode.
Purpose of Change
In the current code, dwChannelMask in the WaveFormatExtensible constructor is set by simply shifting and OR-ing bits based on the number of channels.
However, actual multi-channel audio devices return values that differ from this, because Windows expects the standard speaker placements defined in ksmedia.h and devices follow that specification.
Changes
Tests
Tested with a 4-channel USB audio device (channel mask 0x33 = KSAUDIO_SPEAKER_QUAD).
It cannot play back in WASAPI exclusive mode with the current code, but playback works after this change.