Adds intrinsic acceleration to the SilenceProvider.#947
Open
Zintom wants to merge 2 commits intonaudio:masterfrom
Open
Adds intrinsic acceleration to the SilenceProvider.#947Zintom wants to merge 2 commits intonaudio:masterfrom
SilenceProvider.#947Zintom wants to merge 2 commits intonaudio:masterfrom
Conversation
* If the target framework supports intrinsics (.NET Core 3.0 and up), I define a new `Read` method which uses the power of Avx and Sse to clear the buffer. * Performance tests using BenchmarkDotNet indicate a 8% speedup using this method. * Also, when the DotNet Runtime team add support for `Vector512` this will be able to be optimized even further. * Improved documentation on the Read method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the target framework supports intrinsics (.NET Core 3.0 and up), I define a new
Readmethod which uses the power of Avx and Sse to clear the buffer.Performance tests using BenchmarkDotNet indicate an 8% speedup using this method:
I also improved documentation on the
Readmethod.If this PR is accepted I am more than happy to work on accelerated versions of other Wave providers
Any thoughts/ideas are more than welcome :)