Spapadop/plt 849 statefulset servicename does not match any generated service#27
Merged
spapa013 merged 1 commit intonauticalab:develop/spapadopfrom Mar 6, 2026
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…match StatefulSet serviceName while preserving existing SSH/HTTP services
0cc375e to
af9b0dd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on #26. It should be rebased after #26 is merged
This PR fixes a manifest mismatch where
StatefulSet.spec.serviceNamereferenceddevenv-{{.Name}}but no Service with that name was generated.Changes:
devenv-{{.Name}}headless Service (clusterIP: None) inservice.tmplas the StatefulSet governing service.devenv-ssh-{{.Name}}NodePort Service unchanged.devenv-http-{{.Name}}Service and ingress wiring unchanged.Why
StatefulSets are expected to reference a governing Service (typically headless) for stable pod network identity. This removes the structural mismatch and ensures valid StatefulSet/Service topology.
Validation
go test ./internal/templates -update-goldengo run ./cmd/devenv generate stelios --config-dir ./developers --output ./buildgo test -v -race -covermode=atomic -coverprofile=./coverage.out ./...