Add Cisco CBS350-24XT device type definition#10
Open
dondundonki wants to merge 1 commit intonautobot:mainfrom
Open
Add Cisco CBS350-24XT device type definition#10dondundonki wants to merge 1 commit intonautobot:mainfrom
dondundonki wants to merge 1 commit intonautobot:mainfrom
Conversation
joewesch
reviewed
Feb 3, 2026
| maximum_draw: 125 | ||
| allocated_draw: null | ||
| interfaces: | ||
| - name: '[te]1/0/1' |
Contributor
There was a problem hiding this comment.
Are these interfaces really named [te]? Most other 10gbase-t interfaces for Cisco in this library are TenGigabitEthernet
| interfaces: | ||
| - name: '[te]1/0/1' | ||
| type: 10gbase-t | ||
| mgmt_only: false |
Contributor
There was a problem hiding this comment.
Can you please remove mgmt_only: false from all non-mgmt ports? It just adds noise to the file as that is the default value.
| type: 10gbase-t | ||
| mgmt_only: false | ||
| - name: '[te]1/0/21' | ||
| type: 10gbase-t |
Contributor
There was a problem hiding this comment.
According to the data sheet in the link you provided in the comment, the last 4 interfaces are 10g copper/sfp combo. I think that is supposed to be 10gbase-x-sfpp?
| - name: '[te]1/0/24' | ||
| type: 10gbase-t | ||
| mgmt_only: false | ||
| - name: oob |
Contributor
There was a problem hiding this comment.
Same comment about the name as previous. I do see that we have this name also on one other device (SG550XG-24F-K9), so I'm just double checking that this is correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings!
A small PR to add CBS350-24XT.