refactor: organize the Sources in different files for easier development#339
refactor: organize the Sources in different files for easier development#339
Conversation
nautobot_circuit_maintenance/handle_notifications/sources/email.py
Outdated
Show resolved
Hide resolved
…l.py Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
|
@chadell what do we want to do with this? |
housekeeping, organize the |
|
Looks like pylint has some issues with the changes @chadell |
…ite the lazy imports
…autobot-plugin-circuit-maintenance into refactor-source-notifications
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@chadell what do you think with this? I made a few updates in to help get past the test failures. |
|
@gsnider2195 I'd like to get your eyes on this one more time. |
looks good to me |
|
|
||
|
|
||
| class CircuitMaintenanceBulkEditForm(TagsBulkEditFormMixin, NautobotBulkEditForm): | ||
| class CircuitMaintenanceBulkEditForm(NautobotBulkEditForm, TagsBulkEditFormMixin): |
There was a problem hiding this comment.
Was this not working properly?
| from nautobot_circuit_maintenance.handle_notifications.sources.email import EmailSource | ||
| from nautobot_circuit_maintenance.handle_notifications.sources.gmail import GmailAPI |
There was a problem hiding this comment.
Can we make these importable from nautobot_circuit_maintenance.handle_notifications.sources?
|
|
||
| from .sources import MaintenanceNotification, get_notifications | ||
| from .sources import get_notifications | ||
| from .sources.maintenance_notification import MaintenanceNotification |
There was a problem hiding this comment.
Can we make this importable from .sources?
3 participants
What's Changed
This PR only refactored the
sources.pyinto asourcesmodule breaking down the features per file. Only necessary refactor changes done.To Do