fix: Prefix names starting with numbers with an underscore#322
Open
johannwagner wants to merge 1 commit intonautobot:developfrom
Open
fix: Prefix names starting with numbers with an underscore#322johannwagner wants to merge 1 commit intonautobot:developfrom
johannwagner wants to merge 1 commit intonautobot:developfrom
Conversation
johannwagner
requested review from
itdependsnetworks and
jdrew82
as code owners
Contributor
|
It looks like the |
gsnider2195
reviewed
Sep 24, 2025
| dashes to single dashes. Remove characters that aren't alphanumerics, | ||
| underscores, or hyphens. Convert to lowercase. Also strip leading and | ||
| trailing whitespace, dashes, and underscores. | ||
| Also adds a trailing underscore to names starting with an number to circumvent a bug in the Capirca/Aerleon parser. |
Contributor
There was a problem hiding this comment.
Is this a documented bug? Can we add a link to it here?
Contributor
Author
There was a problem hiding this comment.
They require a word at those places and a word cannot start with a number by definiton:
https://aerleon.readthedocs.io/en/latest/reference/yaml_reference/#value-types
Contributor
There was a problem hiding this comment.
Suggested change
| Also adds a trailing underscore to names starting with an number to circumvent a bug in the Capirca/Aerleon parser. | |
| Also adds a leading underscore to names starting with an number to circumvent a bug in the Capirca/Aerleon parser. |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
Author
|
The slugify function is used in places, where Aerleon requires a word, which is not allowed to start with a number by definiton. I think, it is appropriate and also probably fixes some other unnoted bugs. |
gsnider2195
reviewed
Oct 23, 2025
| @@ -0,0 +1 @@ | |||
| Fixed names starting with numbers by prefixing with an underscore. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Fixed names starting with numbers by prefixing with an underscore. | |
| Fixed an incompatibility when slugifying capirca names that start with a number by prefixing the name with an underscore. |
Contributor
|
Sorry it took me so long to get back to you. Just a couple of suggestions on the wording and we'll get this merged. Thank you! |
6 tasks
nautobot-bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
…r Tool ## [3.0.0 (2025-12-30)](https://github.com/nautobot/cookiecutter-nautobot-app/releases/tag/3.0.0) ### Added - [#291](nautobot/cookiecutter-nautobot-app#291) - Added support for Python `3.13`. ### Changed - [#291](nautobot/cookiecutter-nautobot-app#291) - Updated minimum Nautobot version to `3.0.0`. - [#291](nautobot/cookiecutter-nautobot-app#291) - Updated maximum Nautobot version to `<4.0.0`. - [#309](nautobot/cookiecutter-nautobot-app#309) - Change the tag-nautobot-app workflow to support multiple nautobot-app versions. - [#320](nautobot/cookiecutter-nautobot-app#320) - Upstream testing now runs against selected branches. ### Documentation - [#319](nautobot/cookiecutter-nautobot-app#319) - Fixed nav typo and added missing 2.7.2 release notes. ### Housekeeping - [#322](nautobot/cookiecutter-nautobot-app#322) - Updated CI workflow to always regenerate poetry lockfile. **Full Changelog**: nautobot/cookiecutter-nautobot-app@nautobot-app-v2.7.2...nautobot-app-v3.0.0
nautobot-bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
…r Tool - [#291](nautobot/cookiecutter-nautobot-app#291) - Added support for Python `3.13`. - [#291](nautobot/cookiecutter-nautobot-app#291) - Updated minimum Nautobot version to `3.0.0`. - [#291](nautobot/cookiecutter-nautobot-app#291) - Updated maximum Nautobot version to `<4.0.0`. - [#309](nautobot/cookiecutter-nautobot-app#309) - Change the tag-nautobot-app workflow to support multiple nautobot-app versions. - [#320](nautobot/cookiecutter-nautobot-app#320) - Upstream testing now runs against selected branches. - [#319](nautobot/cookiecutter-nautobot-app#319) - Fixed nav typo and added missing 2.7.2 release notes. - [#322](nautobot/cookiecutter-nautobot-app#322) - Updated CI workflow to always regenerate poetry lockfile. **Full Changelog**: nautobot/cookiecutter-nautobot-app@nautobot-app-v2.7.2...nautobot-app-v3.0.0
gsnider2195
pushed a commit
that referenced
this pull request
Jan 5, 2026
…r Tool (#368) * Cookie updated targeting develop by NetworkToCode Cookie Drift Manager Tool - [#291](nautobot/cookiecutter-nautobot-app#291) - Added support for Python `3.13`. - [#291](nautobot/cookiecutter-nautobot-app#291) - Updated minimum Nautobot version to `3.0.0`. - [#291](nautobot/cookiecutter-nautobot-app#291) - Updated maximum Nautobot version to `<4.0.0`. - [#309](nautobot/cookiecutter-nautobot-app#309) - Change the tag-nautobot-app workflow to support multiple nautobot-app versions. - [#320](nautobot/cookiecutter-nautobot-app#320) - Upstream testing now runs against selected branches. - [#319](nautobot/cookiecutter-nautobot-app#319) - Fixed nav typo and added missing 2.7.2 release notes. - [#322](nautobot/cookiecutter-nautobot-app#322) - Updated CI workflow to always regenerate poetry lockfile. **Full Changelog**: nautobot/cookiecutter-nautobot-app@nautobot-app-v2.7.2...nautobot-app-v3.0.0 * Fix merge conflicts * Disable mysql testing and add note. * Fix merge conflicts --------- Co-authored-by: bakebot <info@networktocode.com> Co-authored-by: Stephen Kiely <stephenkiely87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #319
What's Changed
It prefixes names starting with a number with an underscore.
To Do