Open
Conversation
lamroger-nava
force-pushed
the
roger/catala-infra
branch
from
a652972 to
8ab1ad9
Compare
lamroger-nava
commented
Mar 31, 2026
lamroger-nava
commented
Mar 31, 2026
doshitan
reviewed
Mar 31, 2026
Contributor
doshitan
left a comment
doshitan
left a comment
There was a problem hiding this comment.
Overall looks good. A little clean up and some config tweaks are needed I think.
.grype.yml
Outdated
| - vulnerability: GHSA-v8gr-m533-ghj9 | ||
| - vulnerability: GHSA-mq26-g339-26xf | ||
| - vulnerability: GHSA-3ww4-gg4f-jr7f | ||
| # We dont use imaplib |
Contributor
There was a problem hiding this comment.
Avoid app-specific things here in the project config. This might be true for app-catala, but not other apps.
Contributor
Author
There was a problem hiding this comment.
Makes sense - should we remove the above ones too in a separate PR?
doshitan
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added infra with
nava-platform infra add-app . app-catala.Context for reviewers
Goal for Q1 is a deployable Catala API
Testing
Inited and updated build repo and service
Preview environment for app
Preview environment for app-nextjs
Preview environment for app-flask
Preview environment for app-rails
Preview environment for app-catala