Fix description of VPC security group rule for service#996
Draft
Fix description of VPC security group rule for service#996
Conversation
And add the service name in the description for easier scanning in the AWS Console, which shows the security group ID and description but _not_ the name (which has the service name already embedded).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add the service name in the description for easier scanning in the AWS Console, which shows the security group ID and description but not the name (which has the service name already embedded).
Context for reviewers
Current example from
platform-test, see it only showing the description:Could put the service name as the prefix instead?
${var.service_name}: Allow inbound requests to VPC endpoints from serviceTesting