Fix strict mode validation for nested container expressions and generic types#1236
Closed
Chanwon-Seo wants to merge 8 commits intonaver:mainfrom
Closed
Fix strict mode validation for nested container expressions and generic types#1236Chanwon-Seo wants to merge 8 commits intonaver:mainfrom
Chanwon-Seo wants to merge 8 commits intonaver:mainfrom
Conversation
github-actions
bot
requested review from
SooKim1110,
acktsap,
benelog,
jwChung,
mhyeon-lee and
seongahjo
seongahjo
reviewed
Sep 10, 2025
...c/main/java/com/navercorp/fixturemonkey/expression/StrictModeNextNodePredicateContainer.java
Outdated
Show resolved
Hide resolved
seongahjo
reviewed
Sep 10, 2025
...c/main/java/com/navercorp/fixturemonkey/expression/StrictModeNextNodePredicateContainer.java
Show resolved
Hide resolved
Contributor
Author
|
I've created a test case for this issue, which you can check out at the following link. |
…o fix-strict-mode-nested-list
Contributor
|
@Chanwon-Seo Would you mind if I closed the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes strict mode validation for nested container expressions and generic types by ensuring correct type propagation.
Fixes #1234
(Optional): Description
Ensured
AnnotatedTypeis correctly propagated for container types by usingContainerElementPredicateto traverse into their generic types. Refactored validation logic for clarity.How Has This Been Tested?
Verified with
FixtureMonkeyOptionsTest.strictModeNestedListValidExpression().Is the Document updated?
N/A