-
Notifications
You must be signed in to change notification settings - Fork 116
Add CharacterCombinableArbitrary #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5b89ed to
4425639
Compare
- Update @API annotation version to match CharacterCombinableArbitrary interface
- Use Character.isWhitespace() for accurate whitespace validation - Convert Korean comments to English
- Remove punctuation(), digit(), control(), unicodeCategory() methods
756b2f2 to
9ec4346
Compare
Replace boolean + allMatch patterns with direct value assertions for clearer test intent: - alphabetic, numeric, alphaNumeric tests - ascii, uppercase, lowercase, korean, emoji, whitespace tests - last method wins tests for better conflict resolution verification
9ec4346 to
3ae125b
Compare
seongahjo
approved these changes
Dec 31, 2025
Contributor
seongahjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add CharacterCombinableArbitrary for customizable Character value generation following existing CombinableArbitrary pattern with Character-specific enhancements.
Description
Implemented CharacterCombinableArbitrary to provide easy customization of Character value generation, addressing the lack of character-specific constraints in current API.
Added components:
CharacterCombinableArbitraryinterface with standard constraint methodsCharacterCombinableArbitraryDelegatorfor filter/null injection operationsJqwikCharacterCombinableArbitraryimplementationCombinableArbitrary.chars()Key features:
.alphabetic(),.numeric(),.alphaNumeric(),.withRange(char, char).uppercase()- generates values A-Z for uppercase representation.lowercase()- generates values a-z for lowercase representation.ascii()- generates ASCII printable characters.korean()- generates values 가-힣 for Korean representation.emoji()- generates emoji characters.whitespace()- generates whitespace charactersUsage example:
How Has This Been Tested?
Added comprehensive test suite in
CharacterCombinableArbitraryTest:Is the Document updated?
Documentation will be updated to include CharacterCombinableArbitrary usage examples alongside existing numeric arbitrary types.