feat(timeout): Added timeout parameter to set a webhook response wait timeout.#2
Open
drlove2002 wants to merge 12 commits intonavied:masterfrom
Open
feat(timeout): Added timeout parameter to set a webhook response wait timeout.#2drlove2002 wants to merge 12 commits intonavied:masterfrom
drlove2002 wants to merge 12 commits intonavied:masterfrom
Conversation
signature_sha1 with a sha1= prefix and signature_sha256 with a sha256= prefix
webhook sending fail for internal issues will also be displayed
Timeout will help to stop waiting for response and stop the workflow with a valid nice error message.
- Added how to contribute in this repository. - Added how to test the code. - Updated new code parameter (timeout) - Updated Credit for navied/secure-webhook :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
0means it'll wait forever)Fix
X-Hub-SignatureandX-Hub-Signature-236digests now have prefixes,sha1=andsha256=respectively.Docs
READMEnow contains steps to test the close and collaborate on the project.