Legg til klassifisert-endepunkt, send periode til frontend, lagre begrunnelse #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a classified endpoint, extends the API to send period information to the frontend, and updates the database schema and mapping logic to include a new "begrunnelse" field. Key changes include:
- Package renaming from v1 to api/v1 for improved consistency.
- Addition of period data and "begrunnelse" in both request/response models and DB migrations.
- Introduction of a new endpoint in the v3 API for handling classified income.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dp-inntekt-api/src/test/kotlin/no/nav/dagpenger/inntekt/api/v1/* | Package updates and adjusted imports for test endpoints |
| dp-inntekt-api/src/main/resources/db/migration/* | Added new migration files for period columns and begrunnelse |
| dp-inntekt-api/src/main/kotlin/no/nav/dagpenger/inntekt/* | Updated mapping, mutable period fields, and DB queries to deal with new fields |
| dp-inntekt-api/src/main/kotlin/no/nav/dagpenger/inntekt/api/v3/KlassifisertInntektRouteV3.kt | Introduced new endpoint for classified income with period overrides |
...nntekt-api/src/main/kotlin/no/nav/dagpenger/inntekt/opptjeningsperiode/Opptjeningsperiode.kt
Show resolved
Hide resolved
dp-inntekt-api/src/main/kotlin/no/nav/dagpenger/inntekt/db/PostgresInntektStore.kt
Show resolved
Hide resolved
vskjefst
force-pushed
the
støtte-for-lagring-av-begrunnelse-for-endring
branch
from
fb6cec9 to
323aa67
Compare
vskjefst
force-pushed
the
støtte-for-lagring-av-begrunnelse-for-endring
branch
from
323aa67 to
50bec50
Compare
JMLindseth
force-pushed
the
støtte-for-lagring-av-begrunnelse-for-endring
branch
from
50bec50 to
0f97ffc
Compare
Da blir ikke rota besudlet med pakker ved resjonering av APIet
Ny versjon av det som ligger i InntektRoute. Slår sammen aktørId og fnr til personidentifikator, og tar i tillegg inn periodeFraOgMed og periodeTilOgMed, som erstatter periodene utledet av Opptjeningsperiode gitt beregningsDato.
Eller iallfall tidlig. Hvis VaktmesterTest er den siste testen som kjøres, så feiler uthenting av Prometheus-metrikker.
Frontend har fått denne, og den kommer tilbake til backend i POST-kallet
Fiks også småfeil i sql'en, som også er fikset på main. Verifiser også at det blir med periode ved henting av uklassifisert inntekt, så frontend ikke trenger å beregne det selv. Co-authored-by: Vegard Skjefstad <[email protected]>
…rt inntekt Co-authored-by: Vegard Skjefstad <[email protected]>
Vi må håndtere at den kan være null når vi joiner manuelt_redigert med innntekt. Co-authored-by: Vegard Skjefstad <[email protected]>
Co-authored-by: John Martin Lindseth <[email protected]>
Da er det likt som perioden til hele InntekterDTO. Det er også mer presist.
Co-authored-by: Vegard Skjefstad <[email protected]>
Nå er det mer i tråd med anbefalingene i Nais-konsollen. Co-authored-by: Vegard Skjefstad <[email protected]>
JMLindseth
force-pushed
the
støtte-for-lagring-av-begrunnelse-for-endring
branch
from
4c900dd to
3b7c6e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.