Skip to content

Conversation

eirikmol
Copy link
Contributor

Utkast til sandbox workflow oppdatering

eirikmol and others added 7 commits September 26, 2024 08:47
Change to OTEL Nais Autoinstrumentation
* Migrated to ktor 2, kotlin 2, JDK 21

* Migrated deprecated withTestApplication

* fixes - build sandbox, add back Locations-plugin to main, json ignore unknown

* more metrics
mvn versions:set -DnewVersion="$VERSION" -DgenerateBackupPoms=false -Pgithub-action --batch-mode -DprocessAllModules
mvn clean install
- name: Build and publish Docker image
# mvn clean verify -Pgithub-action -Dmaven.wagon.http.retryHandler.count=3 -Dsurefire.rerunFailingTestsCount=2 -Dlogback.configurationFile="${GITHUB_WORKSPACE}/.github/logback-github.xml" --batch-mode --fail-at-end -T 1.5C
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Her trenger jeg en prat. mvn clean install vs. den lange der med logback osv osv.

Copy link
Contributor

@pcmoen pcmoen Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn clean install er stort sett alltid feil mer enn nødvendig 😊. wagon retry kom på den tiden GitHub var sykt ustabil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Om du skal bytte ut noe så holder det nok å bytte til mvn clean verify

with:
project_id: ${{ vars.NAIS_MANAGEMENT_PROJECT_ID }}
identity_provider: ${{ secrets.NAIS_WORKLOAD_IDENTITY_PROVIDER }}
team: teampensjon
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litt usikker på teampensjon vs. pensjondeployer og hva som er korrekt her.
Appen kjører jo i -ns teampensjon, så tror teampensjon er korrekt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge og se hva som skjer 😄

with:
java-version: 14
distribution: 'temurin'
java-version: '17'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antar at jeg kan bumpe til temurin:17?
Så at dockerfila kjører på det hvertfall.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja det burde gå bra

- name: Build
shell: bash
run: |
mvn versions:set -DnewVersion="$VERSION" -DgenerateBackupPoms=false -Pgithub-action --batch-mode -DprocessAllModules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke legg til denne. Kan forklare på ZOom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants