-
Notifications
You must be signed in to change notification settings - Fork 1
Utkast til sandbox workflow oppdatering #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change to OTEL Nais Autoinstrumentation
* Migrated to ktor 2, kotlin 2, JDK 21 * Migrated deprecated withTestApplication * fixes - build sandbox, add back Locations-plugin to main, json ignore unknown * more metrics
This reverts commit 02d6d7e.
Access for psak gcp
mvn versions:set -DnewVersion="$VERSION" -DgenerateBackupPoms=false -Pgithub-action --batch-mode -DprocessAllModules | ||
mvn clean install | ||
- name: Build and publish Docker image | ||
# mvn clean verify -Pgithub-action -Dmaven.wagon.http.retryHandler.count=3 -Dsurefire.rerunFailingTestsCount=2 -Dlogback.configurationFile="${GITHUB_WORKSPACE}/.github/logback-github.xml" --batch-mode --fail-at-end -T 1.5C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Her trenger jeg en prat. mvn clean install vs. den lange der med logback osv osv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvn clean install
er stort sett alltid feil mer enn nødvendig 😊. wagon retry kom på den tiden GitHub var sykt ustabil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Om du skal bytte ut noe så holder det nok å bytte til mvn clean verify
with: | ||
project_id: ${{ vars.NAIS_MANAGEMENT_PROJECT_ID }} | ||
identity_provider: ${{ secrets.NAIS_WORKLOAD_IDENTITY_PROVIDER }} | ||
team: teampensjon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Litt usikker på teampensjon vs. pensjondeployer og hva som er korrekt her.
Appen kjører jo i -ns teampensjon, så tror teampensjon er korrekt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge og se hva som skjer 😄
with: | ||
java-version: 14 | ||
distribution: 'temurin' | ||
java-version: '17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Antar at jeg kan bumpe til temurin:17?
Så at dockerfila kjører på det hvertfall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja det burde gå bra
- name: Build | ||
shell: bash | ||
run: | | ||
mvn versions:set -DnewVersion="$VERSION" -DgenerateBackupPoms=false -Pgithub-action --batch-mode -DprocessAllModules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ikke legg til denne. Kan forklare på ZOom
Utkast til sandbox workflow oppdatering