Feature/ny sykemelding frontend #3957

stigus · 2025-09-19T12:06:30Z

No description provided.

…syfosmregler and tsm-input-dolly - Changed the setup of the proxy in minor ways #deploy-proxy-sykemelding

…; update tests and configuration files accordingly. #deploy-proxy-sykemelding

…ute. #deploy-proxy-sykemelding #deploy-sykemelding-api #deploy-test-sykemelding-api

#deploy-proxy-sykemelding

…melding commands and configurations.

…ort for new TSM Sykemelding processing and configurations. Fix mapping strategies for consistency. #deploy-test-dolly-backend

…kemeldingClient. Refactor TsmSykemeldingConsumer to support delete operations. #deploy-test-dolly-backend

#deploy-test-dolly-backend

#deploy-proxy-sykemelding

…g files #deploy-test-dolly-backend

…refixes. #deploy-test-dolly-backend

krharum

Startet så vidt et review ...

...ain/java/no/nav/dolly/bestilling/sykemelding/command/SyfosmreglerSykemeldingPostCommand.java

...d/src/main/java/no/nav/dolly/bestilling/sykemelding/command/TsmSykemeldingDeleteCommand.java

...end/src/main/java/no/nav/dolly/bestilling/sykemelding/command/TsmSykemeldingPostCommand.java

...-backend/src/main/java/no/nav/dolly/bestilling/sykemelding/domain/TsmSykemeldingRequest.java

...lly-backend/src/main/java/no/nav/dolly/bestilling/sykemelding/dto/NySykemeldingResponse.java

… `NySykemelding`, update DTO naming conventions, and simplify related methods. #deploy-test-dolly-backend

…gration. - Implement new attributes and validation logic for "Ny Sykemelding". - Refactor existing Sykemelding logic to account for "Ny Sykemelding". - Add dynamic proxy configuration for `testnav-sykemelding-proxy`. - Update SWR hooks and components to handle new sykemelding-related data. - Modify environment-specific configuration files. #deploy-test-frontend

Copilot

Pull Request Overview

This PR introduces a new "ny sykemelding" (new sick leave) frontend feature, adding a simplified sykemelding interface alongside the existing detailed sykemelding functionality.

Adds a new nySykemelding form option with activity periods instead of detailed medical information
Integrates with a new TSM (Team Sykmelding) backend service via proxy
Updates the sykemelding proxy to support routing to both existing syfosmregler and new tsm-input-dolly services

Reviewed Changes

Copilot reviewed 52 out of 55 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
proxies/sykemelding-proxy/src/main/java/no/nav/testnav/proxies/sykemeldingproxy/RouteLocatorConfig.java	Updates proxy routing to handle both syfosmregler and TSM services with path-based routing
apps/dolly-frontend/src/main/js/src/components/fagsystem/sykdom/form/Form.tsx	Adds support for new sykemelding form alongside existing detailed form
apps/dolly-frontend/src/main/js/src/components/fagsystem/sykdom/form/partials/NySykemelding.tsx	Implements the new simplified sykemelding form with activity periods
apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/sykemelding/SykemeldingClient.java	Adds backend integration for new sykemelding service
apps/dolly-frontend/src/main/js/src/components/fagsystem/sykdom/visning/Visning.tsx	Updates display logic to show new sykemelding data when available

Files not reviewed (1)

apps/dolly-frontend/src/main/js/package-lock.json: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-25T11:54:18Z

apps/dolly-frontend/src/main/js/src/components/ui/form/inputs/datepicker/Datepicker.tsx

 		fromDate: minDate,
 		toDate: maxDate,
 		disabled: excludeDates,
+		defaultSelected: convertInputToDate(existingValue)?.toDate?.() || new Date(),


The defaultSelected property is being set to a default value of new Date() when existingValue is undefined or conversion fails. This could cause the datepicker to always show today's date as selected by default, which may not be the intended behavior. Consider using undefined or null instead to allow the datepicker to have no default selection.

Suggested change

defaultSelected: convertInputToDate(existingValue)?.toDate?.() || new Date(),

defaultSelected: convertInputToDate(existingValue)?.toDate?.() ?? undefined,

Copilot · 2025-09-25T11:54:19Z

apps/dolly-frontend/src/main/js/src/components/ui/form/fieldArray/DollyFieldArray.tsx

 	header,
 	newEntry,
-	hjelpetekst = null,
+	hjelpetekst = null as unknown as string,


Using as unknown as string type assertion is unsafe. Consider using proper optional typing like hjelpetekst?: string | null in the interface definition instead of forcing type conversion.

Suggested change

hjelpetekst = null as unknown as string,

hjelpetekst = null,

Copilot · 2025-09-25T11:54:19Z

apps/dolly-frontend/src/main/js/src/components/ui/form/fieldArray/DollyFieldArray.tsx

 	tag = null,
 	isOrganisasjon = false,
-	handleNewEntry = null,
+	handleNewEntry = null as any,


Using as any defeats the purpose of TypeScript's type checking. Consider defining a proper type for handleNewEntry such as (() => void) | null or making it optional with proper typing.

Suggested change

handleNewEntry = null as any,

handleNewEntry = null as (() => void) | null,

Copilot · 2025-09-25T11:54:19Z

apps/dolly-frontend/src/main/js/src/components/fagsystem/sykdom/visning/Visning.tsx


 	const mergeData = () => {
-		const mergeMiljo = []
+		const mergeMiljo: Array<{ data: any[]; miljo: string }> = []


The any[] type for data property reduces type safety. Consider defining a proper interface or type for the data structure to improve maintainability and catch potential runtime errors.

Copilot · 2025-09-25T11:54:20Z

apps/dolly-frontend/src/main/js/src/components/fagsystem/sykdom/visning/Visning.tsx

+				forsteMiljo={forsteMiljo}
+				data={filteredData ?? mergetData}
+			>
+				<Visning data={filteredData} />


The Visning component is being passed filteredData but the component expects data to be from mergetData when filteredData is null/undefined. This could cause the component to receive unexpected data structure. Should use filteredData ?? mergetData instead.

Suggested change

<Visning data={filteredData} />

<Visning data={filteredData ?? mergetData} />

Copilot · 2025-09-25T11:54:20Z

apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/sykemelding/SykemeldingClient.java

 import no.nav.dolly.service.TransactionHelperService;
+import no.nav.dolly.service.TransaksjonMappingService;


[nitpick] Import statements are not in alphabetical order. Consider placing imports in consistent alphabetical order for better code organization.

Suggested change

import no.nav.dolly.service.TransactionHelperService;

import no.nav.dolly.service.TransaksjonMappingService;

import no.nav.dolly.service.TransaksjonMappingService;

import no.nav.dolly.service.TransactionHelperService;

Copilot · 2025-09-25T11:54:20Z

...kend/src/main/java/no/nav/dolly/bestilling/sykemelding/command/NySykemeldingPostCommand.java

+                .retrieve()
+                .bodyToMono(NySykemeldingResponseDTO.class)
+                .doOnError(WebClientError.logTo(log))
+                .onErrorResume(error -> Mono.just(new NySykemeldingResponseDTO(error.getMessage(), "NA", null, request.getIdent())));


Using 'NA' as a hardcoded sykmeldingId in error cases is unclear. Consider using a more descriptive value like 'ERROR' or null, or define a constant for this default value.

# Conflicts: # apps/dolly-frontend/src/main/java/no/nav/dolly/web/DollyFrontendApplicationStarter.java # apps/dolly-frontend/src/main/java/no/nav/dolly/web/config/Consumers.java

…th `undefined` instead of `new Date()` for improved input handling. #deploy-test-frontend

#deploy-test-frontend

…component. #deploy-test-frontend

#deploy-test-frontend

krharum

Lagt til noen kommentarer 👍

apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/sykemelding/SykemeldingClient.java

...nd/src/main/java/no/nav/dolly/bestilling/sykemelding/command/NySykemeldingDeleteCommand.java

...kend/src/main/java/no/nav/dolly/bestilling/sykemelding/command/NySykemeldingPostCommand.java

betsytraran

Dette ble... sykt bra! 🤩

…ture, and enhance response handling in NySykemelding classes. #deploy-test-dolly-backend

stigus added 16 commits September 19, 2025 09:25

- Refactor Consumers and RouteLocatorConfig to support new services: …

1308a45

…syfosmregler and tsm-input-dolly - Changed the setup of the proxy in minor ways #deploy-proxy-sykemelding

Add support for routing syfosmregler and tsm-input-dolly services…

6ffdd0a

…; update tests and configuration files accordingly. #deploy-proxy-sykemelding

Update syfosmregler validation URL; comment out auth filter in TSM ro…

7440613

…ute. #deploy-proxy-sykemelding #deploy-sykemelding-api #deploy-test-sykemelding-api

Enable auth filter for TSM route in RouteLocatorConfig

6c3b525

Enable auth filter for TSM route in RouteLocatorConfig

0c30235

#deploy-proxy-sykemelding

Merge branch 'refs/heads/master' into feature/ny-sykemelding-frontend

f162832

Add support for TSM sykemelding processing and routing; refactor syke…

f7909ee

…melding commands and configurations.

Merge branch 'master' into feature/ny-sykemelding-frontend

e324ba4

Merge branch 'master' into feature/ny-sykemelding-frontend

00b23ed

Refactor Sykemelding handling to remove unused MapperFacade; add supp…

dd2e8ae

…ort for new TSM Sykemelding processing and configurations. Fix mapping strategies for consistency. #deploy-test-dolly-backend

Merge branch 'refs/heads/master' into feature/ny-sykemelding-frontend

a2ace89

Add TSM sykemelding delete command and integrate deletion logic in Sy…

ff35096

…kemeldingClient. Refactor TsmSykemeldingConsumer to support delete operations. #deploy-test-dolly-backend

Deploy backend test

9c2a9af

#deploy-test-dolly-backend

Fix missing newline at EOF in SykemeldingProxyApplicationStarter.

e3e7089

#deploy-proxy-sykemelding

Add reordered proxy rules for sykemelding and other services in confi…

28aff41

…g files #deploy-test-dolly-backend

Simplify status messages in SykemeldingClient by removing redundant p…

1466f6b

…refixes. #deploy-test-dolly-backend

krharum reviewed Sep 25, 2025

View reviewed changes

stigus added 3 commits September 25, 2025 12:44

Refactor Sykemelding classes and logic: replace TsmSykemelding with…

8d6aed2

… `NySykemelding`, update DTO naming conventions, and simplify related methods. #deploy-test-dolly-backend

stigus marked this pull request as ready for review September 25, 2025 11:51

stigus requested a review from a team as a code owner September 25, 2025 11:51

Copilot AI review requested due to automatic review settings September 25, 2025 11:51

Copilot AI reviewed Sep 25, 2025

View reviewed changes

stigus added 5 commits September 25, 2025 13:54

Merge branch 'master' into feature/ny-sykemelding-frontend

a65f32a

# Conflicts: # apps/dolly-frontend/src/main/java/no/nav/dolly/web/DollyFrontendApplicationStarter.java # apps/dolly-frontend/src/main/java/no/nav/dolly/web/config/Consumers.java

- Replace defaultSelected fallback value in Datepicker component wi…

9fe26e3

…th `undefined` instead of `new Date()` for improved input handling. #deploy-test-frontend

- Remove unused data prop from Visning component in MiljoTabs.

9a85674

#deploy-test-frontend

- Remove unused ident prop from VisningAvBestilling in Visning …

665a5f9

…component. #deploy-test-frontend

- Fix typo in help text for "Ny Sykemelding" component.

45b52c4

#deploy-test-frontend

krharum approved these changes Sep 25, 2025

View reviewed changes

betsytraran approved these changes Sep 25, 2025

View reviewed changes

Refactor sykemelding handling: adjust error logging, update DTO struc…

7b231b7

…ture, and enhance response handling in NySykemelding classes. #deploy-test-dolly-backend

stigus merged commit 4e59245 into master Sep 26, 2025
7 of 8 checks passed

stigus deleted the feature/ny-sykemelding-frontend branch September 26, 2025 07:46

	defaultSelected: convertInputToDate(existingValue)?.toDate?.() \|\| new Date(),
	defaultSelected: convertInputToDate(existingValue)?.toDate?.() ?? undefined,

	handleNewEntry = null as any,
	handleNewEntry = null as (() => void) \| null,

	<Visning data={filteredData} />
	<Visning data={filteredData ?? mergetData} />

		import no.nav.dolly.service.TransactionHelperService;
		import no.nav.dolly.service.TransaksjonMappingService;

Feature/ny sykemelding frontend #3957

Feature/ny sykemelding frontend #3957

Uh oh!

Conversation

stigus commented Sep 19, 2025

Uh oh!

krharum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

krharum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

betsytraran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants