Feature/build pipelines for releases#84
Draft
time-by-waves wants to merge 4 commits intonavossoc:masterfrom
Draft
Feature/build pipelines for releases#84time-by-waves wants to merge 4 commits intonavossoc:masterfrom
time-by-waves wants to merge 4 commits intonavossoc:masterfrom
Conversation
…owerShell files to modernize the batch scripts, included some tests, added release workflow
…m-uri Run a Security Audit with ChatGPT 4.5
There was a problem hiding this comment.
Pull Request Overview
This PR adds automated build pipelines for plugin releases, updates project targets to .NET Framework 4.8, and introduces URL credential‐stripping logic with accompanying tests.
- Introduce PowerShell build scripts (
plgx-build.ps1,plgx-build-install-run-loop.ps1) and a GitHub Actions workflow for release packaging. - Update both main and test projects to target .NET Framework 4.8.
- Add
StripUserInfoinFaviconDownloader, logging, and unit tests for credential stripping.
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plgx-build.ps1 | New PS script for cleaning, building, packaging, and deploying plugin |
| plgx-build-install-run-loop.ps1 | Loop script to rebuild, install, and run KeePass on exit |
| YAFD/YetAnotherFaviconDownloader.csproj | Target framework bumped from v4.5 to v4.8 |
| YAFD/Util.cs | Add file-based debug logging |
| YAFD/FaviconDownloader.cs | Add StripUserInfo helper and invoke it in URL validation |
| Tests/Tests.csproj | Updated to .NET 4.8; add test for IsValidURL |
| Tests/IsValidURLTest.cs | New tests covering user‐info stripping |
| SECURITYAUDIT.md | Detailed security audit documentation |
| BUILD.md | New build and run guide |
| .github/workflows/build-and-release.yml | CI workflow for build and release |
Files not reviewed (1)
- YAFD/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (4)
BUILD.md:6
- Update this prerequisite to .NET Framework 4.8 targeting pack to match the project’s updated target framework.
* .NET Framework 4.5 targeting pack (VS installs it)
BUILD.md:53
- [nitpick] This instruction is duplicated later in the file (around line 108); consider removing the redundant block to clean up the documentation.
Include the output of `msbuild -version` and `KeePass.exe --version` when opening build‐related issues.
Tests/IsValidURLTest.cs:28
- Add additional test cases for URLs without a schema when automatic prefixing is enabled and disabled, to verify the prefix logic in
IsValidURL.
[DataTestMethod]
.github/workflows/build-and-release.yml:23
- Invoke the PowerShell script explicitly using
pwsh -NoProfile -ExecutionPolicy Bypass -File .\plgx-build.ps1to ensure it executes correctly on the Windows runner.
run: plgx-build.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.