Add support for option groups in Select and MultiSelect fields
#1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One can simply call `Enum.filter`, instead of a more complicated `Enum.reduce` followed by `Enum.reverse`.
Conversion to string was missing in the else case (the option value could be an atom, therefore it must be converted to a string for proper filtering).
See Phoenix.HTML.Form.options_for_select/2
Additionally, this fixes the `:options` field option not working when passed a list rather than a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! First of all my congrats for Backpex!
Here is a PR with some enhancements:
Enum.reducefollowed byEnum.reversewith a single call toEnum.filterSelectandMultiSelectfields. Option groups are already supported by Phoenix via Phoenix.HTML.Form.options_for_select/2, but don't work out of the box in Backpex. The changes forSelectare a simple fix, the implementation forMultiSelectis just a bit more complicated. See below for some screenshots.I have made other small improvements if you are interested!
Option groups in
Select(as seen in Firefox):Option groups in
MultiSelect: