refactor(components): use generic type params more consistently by nberlette · Pull Request #5 · nberlette/tui

nberlette · 2026-03-10T01:19:22Z

refactor(components): use generic type params more consistently
fix: update broken import path in component.ts
refactor(events): use readonly array for EventEmitter type constraint
fix(tui): updating broken import in tui.ts
feat(internal): support thisArg in SortedArray.sort method
refactor(utils): use more robust global object resolution
fix(canvas): add all missing override modifiers
fix(input): remove stray text from mouse.ts
fix: broken import paths
chore: fmt

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1361a413bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T01:22:27Z

src/utils/runtime.ts

+    return (0, eval)("this") || self || window || globalThis || global;
+  } catch (_) {
+    // deno-lint-ignore no-node-globals
+    return self || window || globalThis || global;


Guard global fallbacks with typeof checks

If eval is unavailable (for example in Node with --disallow-code-generation-from-strings or other CSP-restricted runtimes), execution enters the catch branch and directly references self/window. In environments where those identifiers are undeclared, return self || window || globalThis || global; throws ReferenceError before reaching globalThis, so importing this module fails at startup. Using typeof checks for each global avoids turning the fallback path into a hard crash.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

This PR refactors internal input handling and component typing, while also adjusting a couple of low-level utilities (sorted array sorting and runtime global detection).

Changes:

Replace input_reader imports/exports with the new input module paths across the public surface and core classes.
Tighten component drawnObjects typing by passing the shape via Component/Box generics instead of declare drawnObjects.
Extend SortedArray.sort typing to support a comparator this context and add minor cleanup/override annotations.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/utils/sorted_array.ts	Extends `sort` signature to support `thisArg` binding for comparators.
src/utils/runtime.ts	Reworks global object detection logic used by runtime detection helpers.
src/tui.ts	Updates `InputEventRecord` import to come from `src/input/mod.ts`.
src/layout/mod.ts	Reorders exports (moves `grid_layout` export up).
src/input/mouse.ts	Removes stray unreachable text (`SSS;`) in mouse decode.
src/event_emitter.ts	Adjusts `EmitterEvent` args type constraint to `readonly unknown[]`.
src/components/textbox.ts	Updates `KeyPressEvent` import to `src/input/types.ts`.
src/components/text.ts	Switches to `Component<{ text: TextObject }>` generic for `drawnObjects` typing.
src/components/table.ts	Switches to `Component<...>` generic for `drawnObjects` typing.
src/components/slider.ts	Switches to `Box<...>` generic for `drawnObjects` typing.
src/components/label.ts	Switches to `Component<{ texts: TextObject[] }>` generic for `drawnObjects` typing.
src/components/input.ts	Switches to `Box<...>` generic for `drawnObjects` typing.
src/components/frame.ts	Switches to `Component<...>` generic for `drawnObjects` typing.
src/component.ts	Updates `InputEventRecord` import to come from `src/input/mod.ts`.
src/canvas/text.ts	Adds `override` keywords to methods overriding base class behavior.
mod.ts	Updates public export from `./src/input_reader/mod.ts` to `./src/input/mod.ts`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-10T01:23:42Z

src/utils/runtime.ts

+  try {
+    // deno-lint-ignore no-node-globals
+    return (0, eval)("this") || self || window || globalThis || global;
+  } catch (_) {
+    // deno-lint-ignore no-node-globals
+    return self || window || globalThis || global;
+  }


_global initialization can throw ReferenceError in environments where self, window, globalThis, or global are not defined. Because those identifiers are referenced directly in both the try and catch branches, the catch can also throw, defeating the fallback and potentially breaking module evaluation. Use typeof guards (e.g. typeof self !== "undefined") and/or prefer globalThis when available without referencing undeclared globals; also consider avoiding eval for CSP-restricted environments.

Suggested change

try {

// deno-lint-ignore no-node-globals

return (0, eval)("this") || self || window || globalThis || global;

} catch (_) {

// deno-lint-ignore no-node-globals

return self || window || globalThis || global;

}

if (typeof globalThis !== "undefined") {

return globalThis;

}

if (typeof self !== "undefined") {

return self;

}

if (typeof window !== "undefined") {

return window;

}

// deno-lint-ignore no-node-globals

if (typeof global !== "undefined") {

return global;

}

return {};

Copilot · 2026-03-10T01:23:42Z

src/utils/sorted_array.ts

+    thisArg?: This,
+  ): this {
+    compareFn ??= this.compareFn;
+    if (thisArg) compareFn = compareFn?.bind(thisArg);


if (thisArg) will skip binding when thisArg is a valid falsy value (e.g. 0, "", false), so callers providing such a thisArg will silently not get the intended this in compareFn. Check for thisArg !== undefined (or arguments.length >= 2) instead of truthiness so binding behavior matches the provided argument.

Suggested change

if (thisArg) compareFn = compareFn?.bind(thisArg);

if (thisArg !== undefined) compareFn = compareFn?.bind(thisArg);

- [x] add a dedicated ./signals/errors submodule - [x] move error subclasses out of signal.ts and computed.ts - [x] improve some other minor things

…ntly

refactor: improve signals APIs, add `effect` and `computed` helpers

nberlette added 10 commits February 24, 2026 18:43

refactor(components): use generic type params more consistently

eb93292

fix: update broken import path in component.ts

df01504

refactor(events): use readonly array for EventEmitter type constraint

80aab28

fix(tui): updating broken import in tui.ts

ff19e73

feat(internal): support thisArg in SortedArray.sort method

4bc43a8

refactor(utils): use more robust global object resolution

f1728be

fix(canvas): add all missing override modifiers

3b57fce

fix(input): remove stray text from mouse.ts

4fa52e6

fix: broken import paths

eb3189c

chore: fmt

1361a41

Copilot AI review requested due to automatic review settings March 10, 2026 01:19

nberlette added the components Related to components other than the core label Mar 10, 2026

nberlette self-assigned this Mar 10, 2026

Copilot started reviewing on behalf of nberlette March 10, 2026 01:19 View session

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

Copilot AI reviewed Mar 10, 2026

View reviewed changes

nberlette added 8 commits March 9, 2026 18:24

refactor(signal): improve errors in signal submodules

fc00e78

- [x] add a dedicated ./signals/errors submodule - [x] move error subclasses out of signal.ts and computed.ts - [x] improve some other minor things

feat(utils): add internal performance module for mocking

bb505fa

feat(internal): add internal types and primordials modules

f41fda1

chore: fmt

57df2f4

refactor(signals): clean various little things up

501e914

Document flusher usage

2770675

refactor(signals): clean up formatting, use primordials more consiste…

176b64f

…ntly

Merge pull request #6 from nberlette/refactor/signals

ac71068

refactor: improve signals APIs, add `effect` and `computed` helpers

nberlette merged commit b9dad5b into main Mar 11, 2026
0 of 2 checks passed

nberlette deleted the refactor/components branch March 11, 2026 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(components): use generic type params more consistently#5

refactor(components): use generic type params more consistently#5
nberlette merged 18 commits intomainfrom
refactor/components

nberlette commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-  try {
-    // deno-lint-ignore no-node-globals
-    return (0, eval)("this") || self || window || globalThis || global;
-  } catch (_) {
-    // deno-lint-ignore no-node-globals
-    return self || window || globalThis || global;
-  }
+  if (typeof globalThis !== "undefined") {
+    return globalThis;
+  }
+  if (typeof self !== "undefined") {
+    return self;
+  }
+  if (typeof window !== "undefined") {
+    return window;
+  }
+  // deno-lint-ignore no-node-globals
+  if (typeof global !== "undefined") {
+    return global;
+  }
+  return {};

	if (thisArg) compareFn = compareFn?.bind(thisArg);
	if (thisArg !== undefined) compareFn = compareFn?.bind(thisArg);

Uh oh!

Conversation

nberlette commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants