-
Notifications
You must be signed in to change notification settings - Fork 12
Easy dotnet conventions to verify #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
50fe215
186213e
2ebd2b5
cc82850
a0272d6
482d4d6
5f06394
12f4d0b
b0acb0c
7823ab2
9b8afb3
21f3749
81bfb57
e124a91
eb5f76c
885a60a
4e0c6e1
6e80056
46f3dae
45e298b
c190f9c
d49a99c
19b442d
e6fc879
5358b96
ce4c0c6
18b828e
1fd7576
a326d09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/usr/bin/env -S dotnet fsi | ||
|
|
||
| open System | ||
| open System.IO | ||
|
|
||
| let emptyString = String.Empty |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/usr/bin/env -S dotnet fsi | ||
|
|
||
| open System | ||
| open System.IO | ||
|
|
||
| let emptyString = "" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -586,3 +586,57 @@ let IsExecutableTest2() = | |
| )) | ||
|
|
||
| Assert.That(IsExecutable fileInfo, Is.EqualTo false) | ||
|
|
||
|
|
||
| [<Test>] | ||
| let DefiningEmptyStringsWithDoubleQuotes1() = | ||
| let fileInfo = | ||
| (FileInfo( | ||
| Path.Combine( | ||
| dummyFilesDirectory.FullName, | ||
| "DummyScriptWithConventionalEmptyString.fsx" | ||
| ) | ||
| )) | ||
|
|
||
| Assert.That(DefiningEmptyStringsWithDoubleQuotes fileInfo, Is.EqualTo false) | ||
|
|
||
|
|
||
| [<Test>] | ||
| let DefiningEmptyStringsWithDoubleQuotes2() = | ||
| let fileInfo = | ||
| (FileInfo( | ||
|
||
| Path.Combine( | ||
| dummyFilesDirectory.FullName, | ||
| "DummyScriptWithNonConventionalEmptyString.fsx" | ||
| ) | ||
| )) | ||
|
|
||
| Assert.That(DefiningEmptyStringsWithDoubleQuotes fileInfo, Is.EqualTo true) | ||
|
|
||
|
|
||
| [<Test>] | ||
| let ProjFilesNamingConvention1() = | ||
| let fileInfo = | ||
| (FileInfo( | ||
|
||
| Path.Combine( | ||
| dummyFilesDirectory.FullName, | ||
| "DummyProjFileWithTheSameNameAsItsParentFolder", | ||
| "DummyProjFileWithTheSameNameAsItsParentFolder.fsproj" | ||
| ) | ||
| )) | ||
|
|
||
| Assert.That(ProjFilesNamingConvention fileInfo, Is.EqualTo false) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assert.False?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nope |
||
|
|
||
|
|
||
| [<Test>] | ||
| let ProjFilesNamingConvention2() = | ||
| let fileInfo = | ||
| (FileInfo( | ||
|
||
| Path.Combine( | ||
| dummyFilesDirectory.FullName, | ||
| "DummyProject", | ||
| "DummyProjFileWithoutTheSameNameAsItsParentFolder.fsproj" | ||
| ) | ||
| )) | ||
|
|
||
| Assert.That(ProjFilesNamingConvention fileInfo, Is.EqualTo true) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it easier to use Assert.True?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no, Assert.That is fine |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra parens