fix: Add input for overriding poetry version#18
Open
tiagovrtr wants to merge 5 commits intonborrmann:mainfrom
Open
fix: Add input for overriding poetry version#18tiagovrtr wants to merge 5 commits intonborrmann:mainfrom
tiagovrtr wants to merge 5 commits intonborrmann:mainfrom
Conversation
Signed-off-by: Tiago Reis <tiagovrtreis@gmail.com>
Signed-off-by: Tiago Reis <tiagovrtreis@gmail.com>
Signed-off-by: Tiago Reis <tiagovrtreis@gmail.com>
Signed-off-by: Tiago Reis <tiagovrtreis@gmail.com>
Signed-off-by: Tiago Reis <tiagovrtreis@gmail.com>
Author
|
Any opinions on this @nborrmann ? |
Contributor
|
I've started a fork I'm intending to maintain: https://github.com/colindean/diff-poetry-lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new input
poetry_versionin order to override the latest version during the container build.Adds entrypoint script to reinstall poetry at runtime if this input is set
Sets the default version to the latest v1 version of poetry in order to fix breaking changes introduced by the release of Poetry 2, as reported in #16 .
I suggest in order to support Poetry 2 in the future, to remove the version constraint from
pip install "poetry<2"in /Dockerfile and make the necessary changes topyproject.tomlin a later commit and set a major release at that point to mark that deprecation