fix: resolve GCP monitoring alert policy false negatives#1726
Open
raajheshkannaa wants to merge 1 commit intonccgroup:masterfrom
Open
fix: resolve GCP monitoring alert policy false negatives#1726raajheshkannaa wants to merge 1 commit intonccgroup:masterfrom
raajheshkannaa wants to merge 1 commit intonccgroup:masterfrom
Conversation
Fix hardcoded placeholder string that never matches real alert policies and add missing metric filter name comparison. Fixes nccgroup#1725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1725
Summary
<Log Metric Name>placeholder that never matched real alert policies, causing all 8 CIS GCP monitoring checks to return falseproject_ownership_changes-counter)AND resource.type="global"Changes
ScoutSuite/providers/gcp/resources/stackdrivermonitoring/monitoring_alert_policies.pyTest plan