Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that match_aws() function only works with ipv4 records fetched JSON, ipv4 and not with ipv6
For ipv4 JSON uses following form:
{ "syncToken": "1668133989", "createDate": "2022-11-11-02-33-09", "prefixes": [ { "ip_prefix": "3.2.34.0/26",whereas ipv6 entries use:
"ipv6_prefixes" instead of "prefixes" and "ipv6_prefix" instead of "ip_prefix"
I have added extra condition to cloud_ip_ranges.py so that both ipv4 and ipv6 records work with your script.