Skip to content

Conversation

@hdpriest-ui
Copy link
Collaborator

@hdpriest-ui hdpriest-ui commented Dec 4, 2025

Note

Auto-initializes ICRN Manager on demand, switches catalog layout to R/Python, enhances init with path preview/confirmation, and updates docs/tests accordingly.

  • Manager:
    • Auto-initialize when config missing via check_and_init_if_needed; kernels() reloads config post-init.
    • kernels__init: show paths to be created/modified, prompt for confirmation; supports updating central path; writes config using R/Python subpaths.
    • Default catalog paths switched to R and Python; references updated throughout.
  • Tests:
    • Updated to handle auto-init (added icrn_manager_with_confirm), switched mock repo to R/Python layout.
    • Added tests/cleanup_tests.sh; expanded tests/README.md with suite details and usage; removed committed tests/test_results.log.
  • Docs:
    • Deploy.md: added kernel indexer run steps and web server run instructions with bind mounts.
    • documentation/catalog_resources/README.md: updated directory structure and examples to R/Python hierarchy.
  • Scripts:
    • update_r_libs.sh: updated ICRN_R_KERNELS path to R/.

Written by Cursor Bugbot for commit 3cc5690. This will update automatically on new commits. Configure here.

…existence of user's manager config, and if it is missing triggers the previous 'init' logic

- added preview of affected paths within init function, and asks user for confirmation that they wish to make these changes
- this should only occur the first time the user leverages the system
- updated tests to account for the fact that the individual test environment will need the prompt answered in every test
- resolved bug in which icrn_manager used old style kernel path headings instead of new-style language defaults
@hdpriest-ui hdpriest-ui merged commit 74ea403 into main Dec 4, 2025
1 of 2 checks passed
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

ICRN_PYTHON_KERNELS=${ICRN_KERNEL_REPOSITORY}"/"$(jq -r ".\"icrn_python_kernels\"" "${ICRN_MANAGER_CONFIG}")
ICRN_KERNEL_CATALOG=${ICRN_KERNEL_REPOSITORY}"/"$(jq -r ".\"icrn_kernel_catalog\"" "${ICRN_MANAGER_CONFIG}")
fi
fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Auto-init triggers even with empty/missing subcommand

The kernels() function checks [ "$cmdname" != "init" ] before validating that cmdname is non-empty. When a user runs icrn_manager kernels without specifying a subcommand, cmdname is empty string, which doesn't equal "init", so check_and_init_if_needed() is called prompting for initialization. Only afterwards does the code check if cmdname is empty to display the help message. The empty command check at line 1073 should occur before the auto-initialization logic.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants