fix: Update externallib.php to handle new classes in moodle 4.5 #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hamzakhalem! Thank you for your contribution. The classes were renamed and class aliases were added in Moodle 4.2. The class aliases are still present in Moodle 4.5, 5.0 and - at the moment - the main branch. At this time, we support Moodle 3.7 and newer, so merging this change would break support for Moodle 3.7 through Moodle 4.1. That is okay if - and only if - we are increasing our minimum supported version and increasing our version number to indicate backward incompatibility. So, I will tag this as part of the mod_zoom "next major release" milestone for when it makes sense to drop support for older versions of Moodle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.