Implemented the Display trait for enums to enable to_string usage #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @ndesh26, when you have time can you take a look at this PR? |
Owner
|
Thanks @kimimaru4000 for the pull request! |
ndesh26
added a commit
that referenced
this pull request
Jun 29, 2025
Changes: * Bump evdev to 0.2.6 * Updated libevdev submodule and enums (#112) * Implemented Sync for UInputDevice (#111) * Implemented the Display trait for enums to enable to_string usage (#110) * examples: Use enable instead of enable_event_* * Update to bitflags2 Signed-off-by: Nayan Deshmukh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Displaytrait for many enums to allow usingto_stringon them in user-facing code. SinceEventCodeandInputPropalready implementDisplay, there's a newfmt_blacklistarray that excludes anything within from implementingDisplay.Python Script formatting changes are from the pycodestyle linter.