some ref stuff

Author: ndossche

ext/spl/spl_iterators.c

@@ -3214,7 +3214,7 @@ static const zend_object_iterator_funcs spl_iterator_zip_funcs = {
 	NULL, /* get_gc */
 };
 
-// TODO: by ref support ??? (what happens now when we have a ref-returning generator?)
+// TODO: by_ref support ???
 PHP_FUNCTION(iterator_zip)
 {
 	zval *argv;

ext/spl/tests/iterator_zip.phpt

@@ -44,6 +44,20 @@ foreach (iterator_zip(gen_with_key(0), $a) as $key => $val) {
     unset($key);
 }
 
+function &gen_reference() {
+    $value = 3;
+
+    while ($value > 0) {
+        yield $value;
+    }
+}
+
+foreach (iterator_zip(gen_reference(), gen_reference()) as $vals) {
+    var_dump($vals);
+    --$vals[0];
+    --$vals[1];
+}
+
 ?>
 --EXPECT--
 int(1)
@@ -95,3 +109,21 @@ KEYS: b, y
 VALS: 1, 2
 KEYS: 3, 3
 VALS: 2, 3
+array(2) {
+  [0]=>
+  &int(3)
+  [1]=>
+  &int(3)
+}
+array(2) {
+  [0]=>
+  &int(2)
+  [1]=>
+  &int(2)
+}
+array(2) {
+  [0]=>
+  &int(1)
+  [1]=>
+  &int(1)
+}