Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the near-jsonrpc-client crate to use Rust edition 2024 with resolver version 3, and updates the minimum required Rust version to 1.93.0. However, all three of these version specifications reference non-existent versions as of the current date.
Changes:
- Update Rust edition from 2021 to 2024
- Add resolver version 3
- Update minimum Rust version from 1.67.1 to 1.93.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
17 tasks
vsavchyn-dev
requested changes
Feb 10, 2026
Contributor
vsavchyn-dev
left a comment
vsavchyn-dev
left a comment
There was a problem hiding this comment.
I don't think we need to update MSRV to "stable". As this client might be used with older versions of rust AFAIU.
Maybe only update it to "1.85" to satisfy MSRV for Rust edition 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the crate to Rust edition 2024 with resolver v3.