Skip to content

[filetests]: results pretty-print#247

Open
MCJOHN974 wants to merge 3 commits intomainfrom
viktar/test-results-printing
Open

[filetests]: results pretty-print#247
MCJOHN974 wants to merge 3 commits intomainfrom
viktar/test-results-printing

Conversation

@MCJOHN974
Copy link

Here I implemented pretty printing of error in case of test fail. Need some refactoring in and code style improvements but in general it works

@MCJOHN974 MCJOHN974 marked this pull request as ready for review March 8, 2024 10:54
@MCJOHN974 MCJOHN974 requested review from aborg-dev and mooori March 13, 2024 13:25
Base automatically changed from viktar/filetests to main March 13, 2024 14:18
@MCJOHN974 MCJOHN974 force-pushed the viktar/test-results-printing branch from c3ef7de to a825456 Compare March 13, 2024 17:09
@MCJOHN974
Copy link
Author

This pretty-print PR changes old assert to new one, so it should be merged after whole migrating

@@ -79,6 +98,24 @@ impl SubTest for TestRunZkasm {
debug_assert!(matches!(execution_result.status, ExecutionStatus::Success));
// TODO: Probably here is a good place to collect info generated by assert-hostfunction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addressed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's outdated, thanks


#[derive(Deserialize, Debug, PartialEq)]
#[serde(rename_all = "camelCase")]
enum TestStatus {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enum used anywhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants