feat(bench): Enable aggregating trace in InstructionTracer.js#251
Open
feat(bench): Enable aggregating trace in InstructionTracer.js#251
InstructionTracer.js#251Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
--aggregateoption to theprofile-instructionscommand.For example. the aggregated trace of the
sha256benchmark is:{ "AluRRR": 5043, "Load": 4808, "Store": 2226, "LoadConst64": 2226, "LoadConst32": 1570, "Mov": 1465, "Shru64": 736, "Shl64": 625, "Call": 33, "Jal": 7, "ReserveSp": 5, "ReleaseSp": 5, "VirtualSPOffsetAdj": 2, "Icmp": 2, "CondBr": 2, "Ret": 2, "Args": 1 }Context
We planned to have a discussion whether that kind of aggregation is useful. However, since work on zkwasm will be paused, I think it makes sense to commit this as is to wrap things up. In addition, the
--aggregateoption provides marginal value: