Skip to content

fix: soft-delete instance from DB when instance manager returns 404 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreLeGuen merged 2 commits into from
Feb 22, 2026
Merged

fix: soft-delete instance from DB when instance manager returns 404 #183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46c4b9a
fix: soft-delete instance from DB when instance manager returns 404
PierreLeGuen Feb 21, 2026
34de59c
Merge branch 'main' into fix/soft-delete-on-404
PierreLeGuen Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions crates/services/src/agent/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,15 +1182,22 @@ impl AgentService for AgentServiceImpl {
.await
.map_err(|e| anyhow!("Failed to call Agent API delete: {}", e))?;

if !response.status().is_success() {
return Err(anyhow!(
"Agent API delete failed with status {}: instance_id={}",
response.status(),
instance_id
));
let status = response.status();
if !status.is_success() {
if status == reqwest::StatusCode::NOT_FOUND {
tracing::warn!(
"Instance not found on instance manager (already removed?), proceeding with DB soft-delete: instance_id={}",
instance_id
);
} else {
return Err(anyhow!(
"Agent API delete failed with status {}: instance_id={}",
status,
instance_id
));
}
}

Comment on lines +1187 to 1200
Copy link

@gemini-code-assist gemini-code-assist bot Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to make it easier to handle other status codes in the future, you could use a match statement here to handle the non-success status codes.

Suggested change
if status == reqwest::StatusCode::NOT_FOUND {
tracing::warn!(
"Instance not found on instance manager (already removed?), proceeding with DB soft-delete: instance_id={}",
instance_id
);
} else {
return Err(anyhow!(
"Agent API delete failed with status {}: instance_id={}",
status,
instance_id
));
}
}
if !status.is_success() {
match status {
reqwest::StatusCode::NOT_FOUND => {
tracing::warn!(
"Instance not found on instance manager (already removed?), proceeding with DB soft-delete: instance_id={}",
instance_id
);
}
_ => {
return Err(anyhow!(
"Agent API delete failed with status {}: instance_id={}",
status,
instance_id
));
}
}
}

// Only delete from database if remote deletion was successful
self.repository.delete_instance(instance_id).await?;

tracing::info!(
Expand Down