Skip to content

fix: root path html cache #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
think-in-universe merged 6 commits into from
Nov 26, 2025
Merged

fix: root path html cache #44

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f526bb3
fix: index html cache
think-in-universe Nov 26, 2025
c788de6
fix: serve root with index.html
think-in-universe Nov 26, 2025
e308df5
fix: redirect root url
think-in-universe Nov 26, 2025
2d719cf
fix: version redirect
think-in-universe Nov 26, 2025
3b5b038
style: add comments
think-in-universe Nov 26, 2025
c231561
chore: keep no-cache
think-in-universe Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/api/src/static_files.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use axum::{
body::Body,
http::{header, Request, StatusCode},
response::{IntoResponse, Response},
response::{IntoResponse, Redirect, Response},
};
use std::{env, path::PathBuf};
use tower::ServiceExt;
Expand All @@ -19,6 +19,18 @@ fn frontend_dir() -> PathBuf {
/// Serve static files with SPA fallback and proper cache headers.
pub async fn static_handler(req: Request<Body>) -> Response {
let frontend_dir = frontend_dir();
let uri = req.uri().clone();

// Redirect root to /?v=1 to workaround the cache issue
let needs_version_redirect = uri.path() == "/"
&& uri
.query()
.map(|q| !q.split('&').any(|pair| pair.starts_with("v=")))
.unwrap_or(true);

if needs_version_redirect {
return Redirect::temporary("/?v=1").into_response();
}

let has_extension = req
.uri()
Expand Down Expand Up @@ -47,7 +59,7 @@ pub async fn static_handler(req: Request<Body>) -> Response {
.unwrap_or(false);
// Don't cache HTML files to allow for SPA updates
let cache_value = if is_html {
"no-cache"
"no-cache, no-store, must-revalidate"
} else {
"public, max-age=31536000, immutable"
};
Expand Down