test: run CORS config tests in serial#75
Merged
think-in-universe merged 2 commits intomainfrom Dec 11, 2025
Merged
Conversation
think-in-universe
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the serial_test crate to ensure CORS configuration tests run sequentially, preventing race conditions from concurrent environment variable manipulation. All seven CORS tests that read/write the CORS_ALLOWED_ORIGINS environment variable are now properly marked to run in serial.
- Adds
serial_test = "3.0"as a dev dependency - Marks all CORS config tests with
#[serial_test::serial]attribute to prevent test interference
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/config/Cargo.toml | Adds serial_test dev dependency for test serialization |
| crates/config/src/lib.rs | Adds #[serial_test::serial] attribute to all 7 CORS config tests |
| Cargo.lock | Updates lock file with serial_test and its transitive dependencies (scc, sdd, serial_test_derive) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hanakannzashi
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CORS config tests are quite flaky when running in parallel. The fix run the tests in parallel.