feat: include is_new_user in frontend callback URL#8
Merged
PierreLeGuen merged 5 commits intomainfrom Nov 7, 2025
Merged
Conversation
is_new_user in frontend callbackis_new_user in frontend callback URL
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Rust codebase by updating string formatting to use inline format syntax, adds an is_new_user flag to OAuth callbacks, and introduces a Rust toolchain configuration file.
Key Changes:
- Added
rust-toolchain.tomlto specify Rust version 1.88.0 and required components - Enhanced OAuth callback flow to track and return whether a user is new or existing
- Replaced legacy
format!("{}", var)syntax with modern inline format syntaxformat!("{var}")
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Specifies Rust toolchain version and components |
| crates/services/src/types.rs | Updated test to use inline format syntax |
| crates/services/src/auth/service.rs | Added is_new_user tracking in OAuth flow and updated formatting |
| crates/services/src/auth/ports.rs | Updated OAuthService trait signature to include is_new_user |
| crates/api/tests/e2e_api_tests.rs | Modernized format strings and println statements |
| crates/api/src/routes/oauth.rs | Added is_new_user to callback URL query parameters |
| crates/api/src/routes/api.rs | Updated format strings and improved range check idiom |
| crates/api/src/middleware/auth.rs | Modernized format strings in logging statements |
| crates/api/src/main.rs | Updated error message format string |
| crates/api/src/error.rs | Simplified OAuth provider error message formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PierreLeGuen
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
is_new_userinto frontend callback URL of OAuth login, which is required by PostHog integrationhttps://{frontend_base_url}/auth/callback?token={}&expires_at={}&is_new_user=true