Closed
Conversation
Improvements: • Used modern JavaScript syntax (?., .at(-1), spread operator). • Enhanced readability by simplifying expressions. • Improved consistency in formatting and string operations. • Optimized array operations with .reduce() and .map() where applicable.
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
requested changes
Mar 5, 2025
Member
simoneb
left a comment
simoneb
left a comment
There was a problem hiding this comment.
This PR is introducing many formatting changes that are unrelated to the modifications you are trying to do. Please undo the formatting changes and only include the actual changes to the language syntax.
Contributor
|
I would also avoid removing the for loops in favour of the map + reduce combination. |
Member
|
Closing as outdated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
• Used modern JavaScript syntax (?., .at(-1), spread operator). • Enhanced readability by simplifying expressions. • Improved consistency in formatting and string operations. • Optimized array operations with .reduce() and .map() where applicable.