Skip to content

Conversation

@viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Sep 17, 2024

Reference Issues or PRs

closes #524

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@netlify
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 5b35cb6
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/672a8e8e2c8e780008f02376
😎 Deploy Preview https://deploy-preview-525--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some rewriting

@viniciusdc
Copy link
Contributor Author

@joneszc can you have a look if this PR is okay?

@joneszc
Copy link
Contributor

joneszc commented Nov 5, 2024

@joneszc can you have a look if this PR is okay?

Hello @viniciusdc,

The docs looks great to me, clear and concise. I like the tip on creating a new node group with the desired launch template and migrating workloads to avoid issues with modifying/destroying a node group.

The Test Website check should pass now if you sync/update your branch with upstream.

@viniciusdc viniciusdc merged commit a89196c into main Nov 5, 2024
6 checks passed
@viniciusdc viniciusdc deleted the 524-launch-template branch November 5, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 💪🏾

Development

Successfully merging this pull request may close these issues.

[DOC] - Add docs for node_groups.launch_template

4 participants