-
Notifications
You must be signed in to change notification settings - Fork 35
Add doc on jupyterlab-gallery #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docs/docs/how-tos/jupyter-gallery.md
Outdated
| | ----------- | ---------------------------------------------------------------------------- | | ||
| | title | Title on the gallery tile | | ||
| | git | URL of the git repository | | ||
| | homepage | (Optional) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be used as a link to the examples repository. The idea is to separate the git URL which might contain token (discouraged) from the link shown in the UI (if any).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also used to generate fallback icon from GitHub social cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be used as a link to the examples repository.
As far as I can tell, the UI doesn't link to the repository in any way. If I hover the gallery tile, I just have the options to download or go to the folder. Is this link provided to the users somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, it is not available in the UI. For god security practice the git URL is separated from user facing URL even though it is not currently in the UI. My plan was to add a new button with link icon but I guess it is low priority. It would be rather low effort too though.
docs/docs/how-tos/jupyter-gallery.md
Outdated
| | homepage | (Optional) | | ||
| | description | Description of the repository to appear on the gallery tile (Optional) | | ||
| | icon | base64 encoded image to use an icon to appear on the gallery tile (Optional) | | ||
| | account | (Optional) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you log in using token you need to also pass account. Depending on whether it is GitHub or GitLab it should be a pre-defined string, or any string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is defined in https://github.com/nebari-dev/jupyterlab-gallery/blob/ef56fc616bae4ec8305c01e3341b773ca4cfd48f/jupyterlab_gallery/manager.py#L30-L82
You can access the documentation via jupyterlab-gallery --help-all. I will add it to the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krassowski for account, what does that look like in a github and gitlab url?
For example, if I go to "clone from https" on the nebari-dev repo, it gives this url: https://github.com/nebari-dev/nebari.git . Would the account be nebari-dev or is that my username associate with the token?
For gitlab the "clone from https" could looks like this: https://gitlab.<domain>.net/<projectname>/<teamname>/gradient.git. What is the account here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a part of the URL. It is used during login sequence, the same way as you would login via CLI when issuing say git push on a new machine (by providing a user name and password). Of course you would not because everyone has an SSH key configured instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
krassowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should we do with https://www.nebari.dev/docs/explanations/custom-overrides-configuration#jupyterlab? It includes some important warnings about the PAT/token usage, and feels like a right place to at least keep a mention of gallery_settings. Should it link to this how-to?
| Several repositories can be configured to display as individual gallery tiles. Under the `exhibits` | ||
| section, each repository must have a `title` and a `git` location. There are also several other | ||
| optional config options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: currently the tiles are designed so that they are most beautiful when there is a description. I would personally say that adding description is recommended, but do not want to push it either.
|
@kcpevey @krassowski what's the current status on this? I recently needed this information and relied on the preview here hshshs. Is there anything I can help with? Also, I think the part regarding the use of tokens needs a bit more explanation I primarily relied on the repo readme, the discussions above and actual deployments to grasp what was happening in terms of auth fully. Also, I note that how the extension identifies new commits would be helpful since I was not sure how it would update the clones until I tested it myself. Overall, this tool is fantastic! Huge shout out @krassowski ! |
viniciusdc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will merge this PR so that we have at least a bit more information about this tool, since its been included in nebari since a few versions ago. I will open a follow up issue to read trough all the contents and suggest changes as needed.
We've had several requests for a formalized walkthrough of JupyterLab-Gallery. This PR adds a how to explaining things to users.
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?