Skip to content

Conversation

@joneszc
Copy link
Contributor

@joneszc joneszc commented Oct 24, 2024

Reference Issues or PRs

Fixes #536
Fixes #2746

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@joneszc joneszc self-assigned this Oct 24, 2024
@netlify
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit b4813c4
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/672e41ddcc25a600089e1190
😎 Deploy Preview https://deploy-preview-537--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joneszc joneszc requested a review from viniciusdc October 28, 2024 19:19
@joneszc joneszc requested a review from dcmcand November 5, 2024 15:50
@joneszc
Copy link
Contributor Author

joneszc commented Nov 6, 2024

Hello @viniciusdc @dcmcand
can you please review this docs PR?

Copy link
Contributor Author

@joneszc joneszc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viniciusdc ,

The re-wording looks great, thanks! It was failing Test Website on prettiercheck. Just updated now to remove a single whitespace and replace single quote w/ double quotes on the sample arn.

@joneszc joneszc requested a review from viniciusdc November 8, 2024 16:56
@viniciusdc viniciusdc merged commit 7e458b2 into main Nov 8, 2024
6 checks passed
@viniciusdc viniciusdc deleted the 536-eks-cluster-encryption branch November 8, 2024 18:01
@joneszc joneszc removed the request for review from dcmcand November 8, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 💪🏾

3 participants