Conversation
|
This looks good but I wanted to confirm everything works as expected by running our Azure tests from this branch: https://github.com/nebari-dev/nebari/actions/runs/11628815929 Unfortunately, they failed because of a Vault issue, completely unrelated to this PR. Once we have fixed that, I'll re-trigger them and see if the deployment works in Azure. |
|
Thanks Marcelo, I haven't tested it yet. |
|
@Adam-D-Lewis I re-triggered the Azure deployment workflow now that Vault is working again and found another issue when it tries logging-in: https://github.com/nebari-dev/nebari/actions/runs/11628815929/job/32469625611#step:6:33 Do you recognize this error? |
|
I'll take a look |
|
Sorry I put this as a draft since it's not ready for merge. I'm sure there'll need to be some adjustments made for this to deploy without error, and I haven't had a chance to do so. |
22e409c to
f68d62b
Compare
viniciusdc
left a comment
There was a problem hiding this comment.
Thanks, @dcmcand for the PR! Looks great
Reference Issues or PRs
Fixes #2806
Fixes #2923
What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
Any other comments?