Skip to content

upgrade azurerm to latest version#2812

Merged
dcmcand merged 8 commits intomainfrom
upgrade_azurerm_provider
Feb 11, 2025
Merged

upgrade azurerm to latest version#2812
dcmcand merged 8 commits intomainfrom
upgrade_azurerm_provider

Conversation

@Adam-D-Lewis
Copy link
Copy Markdown
Member

@Adam-D-Lewis Adam-D-Lewis commented Oct 31, 2024

Reference Issues or PRs

Fixes #2806
Fixes #2923

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@marcelovilla
Copy link
Copy Markdown
Member

This looks good but I wanted to confirm everything works as expected by running our Azure tests from this branch: https://github.com/nebari-dev/nebari/actions/runs/11628815929

Unfortunately, they failed because of a Vault issue, completely unrelated to this PR. Once we have fixed that, I'll re-trigger them and see if the deployment works in Azure.

@Adam-D-Lewis
Copy link
Copy Markdown
Member Author

Thanks Marcelo, I haven't tested it yet.

@marcelovilla
Copy link
Copy Markdown
Member

@Adam-D-Lewis I re-triggered the Azure deployment workflow now that Vault is working again and found another issue when it tries logging-in: https://github.com/nebari-dev/nebari/actions/runs/11628815929/job/32469625611#step:6:33

Running Azure CLI Login.
/usr/bin/az cloud set -n azurecloud
Done setting cloud: "azurecloud"
Federated token details:
 issuer - https://token.actions.githubusercontent.com/
 subject claim - repo:nebari-dev/nebari:ref:refs/heads/upgrade_azurerm_provider
Attempting Azure CLI login by using OIDC...
Error: AADSTS700213: No matching federated identity record found for presented assertion subject 'repo:nebari-dev/nebari:ref:refs/heads/upgrade_azurerm_provider'. Please note that the matching is done using a case-sensitive comparison. Check your federated identity credential Subject, Audience and Issuer against the presented assertion. https://learn.microsoft.com/entra/workload-id/workload-identity-federation Trace ID: ea8ccd7f-2663-42b5-9130-450be9707200 Correlation ID: aaf97b77-ef83-4a2e-b225-8ebe0106d6f7 Timestamp: 2024-11-04 10:49:52Z

Error: Interactive authentication is needed. Please run:
az login

Error: Login failed with Error: The process '/usr/bin/az' failed with exit code 1. Double check if the 'auth-type' is correct. Refer to https://github.com/Azure/login#readme for more information.

Do you recognize this error?

@Adam-D-Lewis Adam-D-Lewis changed the title upgrade azurerm to latest 3.x version upgrade azurerm to latest version Nov 4, 2024
@Adam-D-Lewis
Copy link
Copy Markdown
Member Author

I'll take a look

@Adam-D-Lewis Adam-D-Lewis marked this pull request as draft November 15, 2024 15:14
@Adam-D-Lewis
Copy link
Copy Markdown
Member Author

Adam-D-Lewis commented Nov 15, 2024

Sorry I put this as a draft since it's not ready for merge. I'm sure there'll need to be some adjustments made for this to deploy without error, and I haven't had a chance to do so.

@dcmcand dcmcand force-pushed the upgrade_azurerm_provider branch from 22e409c to f68d62b Compare January 29, 2025 11:33
@dcmcand dcmcand marked this pull request as ready for review January 29, 2025 14:16
@dcmcand dcmcand requested review from dcmcand and removed request for dcmcand February 7, 2025 13:51
Copy link
Copy Markdown
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dcmcand for the PR! Looks great

@dcmcand dcmcand added this to the 2025.1.1 release milestone Feb 10, 2025
@dcmcand dcmcand merged commit 3c22840 into main Feb 11, 2025
26 checks passed
@dcmcand dcmcand deleted the upgrade_azurerm_provider branch February 11, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 💪🏾

Development

Successfully merging this pull request may close these issues.

[ENH] - Update azure terraform provider, API retiring in Feb, 2025 Upgrade Azure TF Provider

4 participants