Skip to content

update google terraform version, replace container registry by artifact registry#2902

Merged
dcmcand merged 8 commits intonebari-dev:mainfrom
swapkh91:fix/2894-gcp-migrate-to-artifact-registry
Feb 7, 2025
Merged

update google terraform version, replace container registry by artifact registry#2902
dcmcand merged 8 commits intonebari-dev:mainfrom
swapkh91:fix/2894-gcp-migrate-to-artifact-registry

Conversation

@swapkh91
Copy link
Contributor

@swapkh91 swapkh91 commented Jan 8, 2025

Reference Issues or PRs

Fixes #2894

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  • Setup nebari on GCP as per the docs
  • The deployment will fail at step module.registry-jupyterhub
  • Update hashicorp/google version in stages/02-infrastructure/gcp/versions.tf and stages/01-terraform-state/gcp/main.tf to 6.14.1
  • Change stages/02-infrastructure/gcp/modules/registry/main.tf to
resource "google_artifact_registry_repository" "registry" {
  location = <region as selected in init phase>
  format = "DOCKER"
  repository_id = <nebari-project-name>-dev
}
  • Run nebari deploy -c nebari-config.yaml --disable-render

Any other comments?

@swapkh91
Copy link
Contributor Author

swapkh91 commented Jan 8, 2025

@dcmcand @viniciusdc i've opened the PR as per my novice understanding, please review :)

@viniciusdc
Copy link
Contributor

viniciusdc commented Jan 22, 2025

Thanks, @swapkh91, for the PR! We will include it in our next release, scheduled for February 2025.2.1.

@dcmcand dcmcand added needs: review 👀 This PR is complete and ready for reviewing provider: GCP labels Jan 23, 2025
@dcmcand dcmcand added this to the 2025.2.1 Release milestone Jan 23, 2025
@viniciusdc viniciusdc added the impact: high 🟥 This issue affects most of the nebari users or is a critical issue label Jan 28, 2025
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for this @swapkh91

@dcmcand dcmcand merged commit e4958bb into nebari-dev:main Feb 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact: high 🟥 This issue affects most of the nebari users or is a critical issue needs: review 👀 This PR is complete and ready for reviewing provider: GCP

Projects

Status: Done 💪🏾

Development

Successfully merging this pull request may close these issues.

Deploy and upgrade nebari on GCP fails because provider needs updated

4 participants