enhancement : Moved Docker images repo to docker folder in main branch by Helion55 · Pull Request #2932 · nebari-dev/nebari

Helion55 · 2025-02-01T04:43:23Z

Reference Issues or PRs

Fixes #2871

What does this implement/fix?

Other (please describe):

Moved docker-images repo back to main nebari's repo. Changes made,

Created folder named docker and moved the necessary files from docker repository.
Updated the .github/workflows folder by adding the build-push-docker.yaml and test-images.yaml files from docker repo's workflow folder.
Added documentation.yml and RFD.md files to .github/ISSUE_TEMPLATE folder.
Updated .pre-commit-config.yaml file.

Testing

Did you test the pull request locally?
no
Did you add new tests?
no

Any other comments?

no

viniciusdc · 2025-02-03T15:27:45Z

Hey @Helion55 thanks for opening this PR! we will have a look during the following days, in nebari we use pre-commit to lint the files and commit changes; its just a few typos, but if you want then to be self-fixed, you can pip install pre-commit and run pre-commit install that should then run in your next commit. For now, this is the line that currently needs changes:

error: `statis` should be `stasis`, `status`
  --> docker/scripts/install-conda-environment.sh:56:29

viniciusdc · 2025-02-17T15:50:50Z

Hey, @ Helion55, I am giving you a heads-up on the review status. We are finishing the latest release of Nebari. Once that's out,, we will include this PR on our discussion board next week. Once again, thanks for opening the PR!

Helion55 · 2025-02-17T17:04:02Z

Thanks @viniciusdc, I was curious about it. I have fixed the thing that you had mentioned. Waiting to catch up on next week.

docker/Dockerfile.dask-worker

@@ -0,0 +1,41 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.dask-worker

@@ -0,0 +1,41 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.jupyterhub

@@ -0,0 +1,41 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.jupyterhub

@@ -0,0 +1,41 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.jupyterlab

@@ -0,0 +1,70 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.jupyterlab

@@ -0,0 +1,70 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.workflow-controller

@@ -0,0 +1,61 @@
+# Copyright (c) Nebari Development Team.


docker/Dockerfile.workflow-controller

@@ -0,0 +1,61 @@
+# Copyright (c) Nebari Development Team.


viniciusdc · 2025-02-25T17:56:30Z

Will start looking into it today

viniciusdc · 2025-03-17T15:40:01Z

Hey @Helion55, I did a quick look at your PR. Since this will be an initial part of a big file move, I would like to disable or not copy the action files initially. Also, we will be making some changes this week in that repo to make things faster to build and more stable overall, so you will probably need to copy/modify the files again.

In the meantime, to not leave you empty-handed, feel free to check any of our issues with Help Needed to Good First Issue labels.

Helion55 · 2025-03-18T07:32:08Z

Thanks @viniciusdc, Sure, I will do that.

Helion55 · 2025-04-23T03:46:28Z

Hello, I have removed those two workflow files; kindly check the PR now. And I apologize for my delayed activity.

viniciusdc · 2025-06-05T15:32:28Z

Hey @Helion55 sorry I missed your message, thanks. I will need to have a look at this later on...though you might need to copy the files again since a lot has changed in that repo since then

Helion55 · 2025-06-14T10:11:21Z

Sure @viniciusdc . I'll check and copy them.

…24.04 (#213) commit

…213) commit

…rfile misconfigurations (#214) commit

Helion55 · 2025-06-20T12:53:26Z

Hi team, I have updated the branch with the latest commits from nebari-docker-images repo. Kindly check once.

viniciusdc · 2025-06-27T17:43:27Z

Thanks @Helion55, I will have time next week to look into this

viniciusdc · 2025-06-28T18:45:37Z

.github/ISSUE_TEMPLATE/RFD.md

@@ -0,0 +1,52 @@
+---


These template files are not needed

Hi @viniciusdc, is it fine now?

Yes, thanks! I need to take a closer look at what we need to do internally to make this all work from here. I haven't had the time to do so yet, but I plan to check this later today or tomorrow, or next Wednesday.

viniciusdc · 2025-07-23T15:12:22Z

Hey @Helion55 sorry this got quite shifted, I hope to have some time to look into it this Friday

viniciusdc · 2025-07-23T15:14:05Z

Also, I suggest you create feature branches in your Fork and create the PRs from those instead of from your main. This gets your git history clean and entirely in sync with ours.

Helion55 · 2025-10-30T06:34:44Z

Hi @viniciusdc, Now I have created a PR for this from a separate feature branch. Kindly check once #3177.

Helion55 added 4 commits February 1, 2025 09:38

Dockerfiles added

5f751d3

workflow updated for docker setup

48bcb2d

added documention and rfd from docker repo

d5c0387

Update .pre-commit-config.yaml from docker repo

6bda9fd

Merge branch 'main' into main

c9710cb

dcmcand requested a review from a team as a code owner February 7, 2025 14:49

dcmcand requested review from dcmcand and marcelovilla and removed request for a team February 7, 2025 14:49

Helion55 added 3 commits February 7, 2025 22:14

Added Readme.md from the docker repository

a94a2c2

Merge branch 'main' into main

9d3fe5d

Update install-conda-environment.sh

99fe60a

Merge branch 'main' into main

3251349

github-advanced-security bot found potential problems Feb 20, 2025

View reviewed changes

viniciusdc added the status: in review 👀 This PR is currently being reviewed by the team label Feb 25, 2025

dcmcand assigned viniciusdc Mar 6, 2025

dcmcand requested a review from viniciusdc March 6, 2025 12:09

dcmcand moved this from New 🚦 to In review/QA 👀 in 🪴 Nebari Project Management Mar 6, 2025

marcelovilla moved this from In review/QA 👀 to TODO 📬 in 🪴 Nebari Project Management Mar 20, 2025

Helion55 added 2 commits April 23, 2025 09:06

Removed .github/workflows/build-push-docker.yaml

d23853b

Removed .github/workflows/test-images.yaml

7ec2f06

Helion55 added 19 commits June 20, 2025 17:56

Delete docker/jupyterlab/apt.txt

740ecbe

Upgrade JupyterHub to 5.3.0

8bd4511

Delete docker/nebari-workflow-controller/apt.txt

51ed4c2

Update install-code-server.sh from optimize dockerfile (#211) commit

f5d32a8

Update install-code-server.sh from optimize dockerfile (#211) commit

0c1bd93

Update install-conda.sh from optimize dockerfile (#211) commit

41e851a

Update install-code-server.sh from optimize dockerfile (#211) commit

82ec35a

Delete docker/scripts/install-apt-minimal.sh

1844d7d

Delete docker/scripts/install-apt.sh

d6730bf

Delete docker/Dockerfile.dask-worker

7ca9de4

Delete docker/Dockerfile.jupyterhub

d9e352f

Delete docker/Dockerfile.jupyterlab

686d04a

Delete docker/Dockerfile.workflow-controller

d2ec3ec

Created Dockerfile from Update base images to use Ubuntu 24.04 (#213)

02f9a79

Created makefile from optimize dockerfile (#211) commit

4a91c3e

Updated README.md from optimize dockerfile (#211) commit

5b87da4

Created build_push_docker.yaml from Update base images to use Ubuntu …

2457d6a

…24.04 (#213) commit

Create test_images.yaml from Update base images to use Ubuntu 24.04 (#…

358c8d0

…213) commit

Created docker_trivy.yaml from Set up Trivy config scanning for Docke…

f7a5650

…rfile misconfigurations (#214) commit

viniciusdc reviewed Jun 28, 2025

View reviewed changes

Helion55 added 2 commits July 1, 2025 19:09

Delete .github/ISSUE_TEMPLATE/RFD.md

b71ceab

Merge branch 'main' into main

547f932

Merge branch 'main' into main

02bb87a

Merge branch 'nebari-dev:main' into main

916b891

Helion55 closed this by deleting the head repository Oct 30, 2025

Conversation

Helion55 commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues or PRs

What does this implement/fix?

Moved docker-images repo back to main nebari's repo. Changes made,

Testing

Any other comments?

Uh oh!

viniciusdc commented Feb 3, 2025

Uh oh!

viniciusdc commented Feb 17, 2025

Uh oh!

Helion55 commented Feb 17, 2025

Uh oh!

Check failure

Check notice

Check failure

Check notice

Check failure

Check notice

Check failure

Check notice

viniciusdc commented Feb 25, 2025

Uh oh!

viniciusdc commented Mar 17, 2025

Uh oh!

Helion55 commented Mar 18, 2025

Uh oh!

Helion55 commented Apr 23, 2025

Uh oh!

viniciusdc commented Jun 5, 2025

Uh oh!

Helion55 commented Jun 14, 2025

Uh oh!

Helion55 commented Jun 20, 2025

Uh oh!

viniciusdc commented Jun 27, 2025

Uh oh!

viniciusdc Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Helion55 Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

viniciusdc Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

viniciusdc commented Jul 23, 2025

Uh oh!

viniciusdc commented Jul 23, 2025

Uh oh!

Helion55 commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Helion55 commented Feb 1, 2025 •

edited

Loading

viniciusdc Jun 28, 2025 •

edited

Loading