support KubeSpawner profile_options#2937
Conversation
|
Failing "Local Integration Tests" test unrelated to this PR |
aktech
left a comment
There was a problem hiding this comment.
This looks good. Verified it works fine with or without jhub-apps enabled. I would be nice to add a cli validation test, by adding a working config here.
For posterity:
Although one thing to note is, its not fully compatible with jhub-apps as in when you deploy app you can't chose different docker images like you can when you create a jupyterlab.
To make it fully compatible with jhub-apps server options we would need to change the UI in jhub-apps and use the newly added profile options, but since that's beyond the scope of this PR, its not a blocker.
|
@Adam-D-Lewis in your docs PR, can you add this as a note:
|
viniciusdc
left a comment
There was a problem hiding this comment.
LGMT, this will also make the notion of "profiles" and the jupyterlab docker images more clear to new users
|
@Adam-D-Lewis I included a label to not merge the PR as a freeze in new additions to Nebari until the current release is out. As soon as its out, we can merge this one! |


Reference Issues or PRs
Kubespawner has support to configure various docker images (or other options) per profile. See
profile_optionsin their docs. We didn't support it in our Pydantic models so this adds support. I tested it and it worked on my local deployment.I made a companion docs PR as well
What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
Add this section to a nebari config.
then ensure the profile selection page looks something like

It works whether or not jhub_apps is enabled.
Any other comments?