Fix issue with namespaces permission scopes#2946
Closed
viniciusdc wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
|
@viniciusdc can you fill out the "How to test" section for this pr? |
Contributor
Author
Hey @dcmcand thanks for the ping, I've updated the description. |
Member
|
I'm closing this PR for now as we're not seeing the issue in our Playwright tests anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
I found a minor issue with the current conda-store UI check in the playwright tests; if the user has admin access over more than its namespace, the current locator (HTML ARIA tagging) returns multiple "create envs" buttons, which breaks the rest of the current logic.:
This PR filters out to only the user namespace while also loosening the assertion with the expected default namespace against the cluster's current namespaces (if the user has more groups than the default, this returns an error in the assert right now):
Put a
xin the boxes that applyTesting
How to test this PR?
/tests/.../playwright/READMEfor setup (make setupis your friend),pytest test_playwright.py::test_conda_store_ui --numprocesses auto -vvv --slowmo 300Any other comments?