Skip to content

fix ansi color reset bug#2970

Merged
marcelovilla merged 1 commit intomainfrom
fix_ansi_color_reset_bug
Mar 4, 2025
Merged

fix ansi color reset bug#2970
marcelovilla merged 1 commit intomainfrom
fix_ansi_color_reset_bug

Conversation

@Adam-D-Lewis
Copy link
Copy Markdown
Member

@Adam-D-Lewis Adam-D-Lewis commented Mar 3, 2025

Reference Issues or PRs

Deploy local. This is what the logs look like at the end (see image).
image

Notice the green ansi coloring continues after tofu logs are complete. This PR sets the ansi reset code at the end of the log capture fixing the issue.

After this fix they look like
image

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Deploy locally, and see that the log coloring looks correct at the end of the deployment.

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested a review from a team as a code owner March 3, 2025 23:22
@Adam-D-Lewis Adam-D-Lewis requested review from marcelovilla and viniciusdc and removed request for a team March 3, 2025 23:22
@marcelovilla marcelovilla added this to the 2025.3.1 release milestone Mar 4, 2025
Copy link
Copy Markdown
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adam-D-Lewis 🚀 ! Just tested this and works fine now.

@marcelovilla marcelovilla merged commit d92b1c1 into main Mar 4, 2025
26 checks passed
@marcelovilla marcelovilla deleted the fix_ansi_color_reset_bug branch March 4, 2025 09:30
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 💪🏾

Development

Successfully merging this pull request may close these issues.

2 participants