Fix Nebari Destroy on GCP (deletion_protection=False)#3169
Merged
Adam-D-Lewis merged 2 commits intomainfrom Oct 30, 2025
Merged
Fix Nebari Destroy on GCP (deletion_protection=False)#3169Adam-D-Lewis merged 2 commits intomainfrom
Adam-D-Lewis merged 2 commits intomainfrom
Conversation
Add deletion_protection = false flag to google_container_cluster resource to allow cluster destruction without requiring a two-step process. This resolves the error that occurs when running 'nebari destroy' on GCP clusters with Google Terraform provider version 5.0.0+. Fixes #3098 Co-Authored-By: Claude <noreply@anthropic.com>
Adam-D-Lewis
requested review from
marcelovilla and
viniciusdc
and removed request for
a team
Adam-D-Lewis
changed the title
Adam-D-Lewis
changed the title
dcmcand
approved these changes
Oct 30, 2025
Adam-D-Lewis
deleted the
claude/fix-github-issue-3098-011CUY1fTFwyp7iDYcmgutDj
branch
github-project-automation
bot
moved this from New 🚦
to Done 💪🏾
in 🪴 Nebari Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deletion_protection = false flag to google_container_cluster resource to allow cluster destruction without requiring a two-step process. This resolves the error that occurs when running 'nebari destroy' on GCP clusters with Google Terraform provider version 5.0.0+.
Fixes #3098
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyDocumentation
Testing
How to test this PR?
Any other comments?