Conversation
|
That error is handled by us here: nebari/tests/tests_deployment/utils.py Lines 47 to 62 in b63040b I have a feeling the client API on the newer keycloak might have moved a few settings to other places, usually, I see those XSRF errors when there is a misconfiguration within the OAuth client. We are currently passing through that stage during deployment, but it might be beneficial to update the provider as well, depending on how the API is called under the hood. I think something else is erroring out, and it ends up being picked by that try block. I would compare the keycloak clients configuration available on a deploy from this branch vs a current deployment to see if there is anything that pops up -- usually at the redirection URLs. Since I see some errors with missing groups tests/tests_deployment/test_conda_store_roles_loaded.py::test_conda_store_roles_loaded_from_keycloak[admin!namespace=analyst,developer!namespace=nebari-git-changed_scopes0] - KeyError: 'nebari-git/*'
FAILED tests/tests_deployment/test_conda_store_roles_loaded.py::test_conda_store_roles_loaded_from_keycloak[admin!namespace=analyst,developer!namespace=invalid-namespace-changed_scopes1] - KeyError: 'analyst/*'
FAILED |
- Upgrade from keycloak chart (15.0.2) to keycloakx chart (7.1.3) - Move PostgreSQL from subchart to standalone deployment - Add Upgrade_2025_10_1 step with database backup prompt - Add UPGRADE_STEPS.md with detailed migration guide - Update RELEASE.md with breaking changes and upgrade instructions
12e9815 to
9b77ba9
Compare
|
uhm... when trying to run a deploy against the current version on
The first one makes sense with the direction we took for this upgrade: |
|
Disregard that: because I was using the main branch version, the upgrade migration workflow was not triggered, since the version only differed by the commit hash... Rookie mistake hahaha, will re-test now |
|
This is nice, but it does not include the command for the user to perform the backup after the deployment suceeds and what to do after it (e.g after everything works, and they want to remove the old instance for example): |
|
working beautifully well |
Requested changes have been implemented
viniciusdc
left a comment
There was a problem hiding this comment.
LGTM, tested on live deployments of both GCP and AWS, upgrade command steps were clear as well as the migration.
Reference Issues or PRs
Fixes #2495
What does this implement/fix?
Put a
xin the boxes that applySoftware update for Keycloak
Documentation
Testing
How to test this PR?
2025.10.1versionnebari upgrade -c <config_file>to automatically generate a backup of keycloaknebari deploy -c <config_fileand the keycloak database will be restored to the new databaseAny other comments?