2. feat: workspace handler local-mode enhancements + DB migrations #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Source/Path fields to server Workspace model for local-mode provenance tracking. Workspace handler constructor takes isLocal flag; ListWorkspaces returns all workspaces in local mode. Add SavePixiToml PUT endpoint. Register store Config/Credentials tables in server DB migrations with singleton row seeding. Executor returns workspace path directly for source=local workspaces.
Adam-D-Lewis
force-pushed
the
workspace-local-mode
branch
from
a3c57b1 to
b03064c
Compare
Adam-D-Lewis
changed the title
- Skip filesystem deletion for source=local workspaces (#1) - Reject source=local in team mode (#2) - Remove store coupling from db.go; use dialect-agnostic GORM calls (#3, #9) - Change variadic isLocal to plain bool (#4) - Migrate store tables conditionally in server.go/app.go (#5) - Validate source enum on CreateWorkspace (#6) - Require absolute path for local workspaces (#7) - Add missing Swagger failure annotations to SavePixiToml (#8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SourceandPathfields to servermodels.Workspacefor local-mode provenance trackingisLocalflag;ListWorkspacesreturns all workspaces in local mode (no ownership filtering)SavePixiTomlPUT endpoint (/workspaces/:id/pixi-toml)store.Configandstore.Credentialstables in server DB migrations with singleton row seedingsource=localworkspacesTest plan
go vet ./...passesgo test ./internal/store/... ./cmd/nebi/...passes/workspaces/:id/pixi-tomlsaves content to diskDepends on: #88