3. refactor: extract shared service layer (internal/service/) #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move workspace business logic from HTTP handlers into a standalone service package so the CLI can call the same functions directly for local ops without an HTTP server. Extracted methods: List, Get, Create, Delete, GetPixiToml, SavePixiToml, PushVersion, ListVersions, GetVersion, GetVersionFile, ListTags. Handlers become thin HTTP wrappers that parse params, call the service, and map typed errors (ErrNotFound→404, ValidationError→400, ConflictError→409) to status codes. Non-extracted methods (Install, Remove, Share, Publish, Rollback) remain in handlers unchanged for now.
Cover delete behavior (managed removes dir, local preserves dir), GetWorkspacePath routing, and normalizeEnvName edge cases.
- PushVersion: check tag conflict before file writes and version creation to prevent orphaned records on conflict - GetPixiToml: distinguish os.IsNotExist (→404) from other filesystem errors (→500) instead of masking all as not-found - handleServiceError: log unhandled errors with slog.Error before returning generic 500 - ListTags: return raw models.WorkspaceTag from service, move timestamp formatting to handler (removes presentation logic from service layer)
21 tests covering Create validation (defaults, invalid source, local-mode restrictions, path requirements), List filtering (local returns all, team filters to owner), Get/Delete not-found, PushVersion tag conflict (with and without force, no orphaned records), pixi.toml round-trip and error handling (missing file vs permission error), ListVersions, GetVersion, and ListTags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
internal/service/WorkspaceServiceErrNotFound,ValidationError,ConflictError) with clean HTTP status mapping viahandleServiceErrorKey changes
internal/service/workspace.go— 11 methods: List, Get, Create, Delete, GetPixiToml, SavePixiToml, PushVersion, ListVersions, GetVersion, GetVersionFile, ListTagsinternal/service/errors.go— Typed errors for 404/400/409 mappinginternal/service/types.go— CreateRequest, PushRequest, PushResultinternal/api/handlers/workspace.go— Refactored to thin wrappers withhandleServiceErrorinternal/api/router.go— Createsservice.New()and passes to handlerReview fixes applied
os.IsNotExistvs other errors (proper 404 vs 500)slog.Errorfor unhandled errorsTest plan
go vet ./...go test ./internal/service/...— 21 unit tests covering all service methodsgo test ./internal/store/... ./cmd/nebi/...cd frontend && npx tsc --noEmit— no type errors