Conversation
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for server-provided feature flags by persisting them into a systemd EnvironmentFile and triggering agent restarts when flags change, plus a Docker-based integration test harness to validate the behavior.
Changes:
- Implement feature-flag validation, environment file generation, and restart gating logic in the updater application.
- Add OS/systemd helper support for restarting services and extend the agent interface to expose an environment file path.
- Introduce Docker Compose–based integration tests with a mock gRPC server and a fake agent, and wire these into CI.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/application/application.go |
Adds feature flag validation, env file writing, and restart decision logic. |
internal/application/application_test.go |
Adds unit tests for env file generation/validation and restart gating behaviors. |
internal/agents/interface.go |
Extends AgentData with GetEnvironmentFilePath(). |
internal/agents/o11y-agent.go |
Implements env file path + real restart via systemd for O11y agent. |
internal/osutils/oshelper.go |
Adds RestartService() helper used by agent restart. |
internal/client/client.go |
Supports insecure gRPC credentials when configured. |
internal/client/client_test.go |
Updates mocks to satisfy the extended agent interface. |
tests/integration/* (multiple files) |
Adds mock server, fake agent, docker images/compose, and integration test suite covering feature flags + restarts. |
Makefile |
Separates unit tests from integration tests and adds integration-test target. |
.github/workflows/check.yaml |
Runs integration tests in CI. |
go.mod / go.sum |
Adds Docker client dependencies and updates module versions required by new tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
holycheater
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.